Global: View result counter gives 1 1 2 3 4 5 (notice the repeated "1" in position 2).

CommentFileSizeAuthor
#2 views_row_index-091001.patch589 bytesiva2k

Comments

iva2k’s picture

iva2k commented
Project: Signup » Views (for Drupal 7)
Status: Active » Needs review

Though it is seen on Signup view, I think the bug is in Views. Moving to Views.

iva2k’s picture

iva2k commented
StatusFileSize
new views_row_index-091001.patch589 bytes

Attached is a patch to views/theme/theme.inc that solves this problem. Should be applied in sites/all/modules/views/theme.

Please review for commit into 6.x-2.x-dev. The patch is a small 1.5-liner and addresses obvious logic problem in the loop $count code.

budda’s picture

budda
Primary language English
Location Cheshire
commented
Status: Needs review » Reviewed & tested by the community

nice catch and logic change patch worked for me. Small enough not to need many testers I think?

merlinofchaos’s picture

merlinofchaos commented
Status: Reviewed & tested by the community » Closed (won't fix)

This patch is no longer relevant as this code has been moved.

merlinofchaos’s picture

merlinofchaos commented
Status: Closed (won't fix) » Fixed

ahh but the error still existed. That is fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

trailerparkopera’s picture

trailerparkopera commented

We had a similar issue this week. We upgraded to 6.2.8 and all of a sudden the Global counter stopped working (only returned a 1 for each entry).

I upgraded to current version of 6.2.0.dev didn't solve it. We finally replaced the views_handler_field_counter.inc in the /handlers directory with an earlier version from (I believe 6.2.6 -- June, 09) and got it working again.

kobee’s picture

kobee commented
Version: 6.x-2.x-dev » 6.x-2.12
Status: Closed (fixed) » Active

Hi, still the same problem (only returned a 1 for each entry) on 6.x.2-12.
Can you patch and Commit?
Thanks.

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Closed (fixed)

@kobee

Which style do you use? Please create an issue on the issue queue of the project.

Anonymous’s picture

Anonymous (not verified) commented
Version: 6.x-2.12 » 7.x-3.0-rc1
Status: Closed (fixed) » Active

I'm getting this same error using 7.8 and the newest stable views release.

It's outputting 1, 1, 2, 3

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Postponed (maintainer needs more info)

Could you please provide an export of the view? it would at least be helpful to reproduce the issue.

Anonymous’s picture

Anonymous (not verified) commented
Status: Postponed (maintainer needs more info) » Active

$view = new view;
$view->name = 'favorite_merchants';
$view->description = 'Favorite merchants per city';
$view->tag = 'default';
$view->base_table = 'node';
$view->human_name = 'Favorite Merchants';
$view->core = 7;
$view->api_version = '3.0-alpha1';
$view->disabled = FALSE; /* Edit this to true to make a default view disabled initially */

/* Display: Master */
$handler = $view->new_display('default', 'Master', 'default');
$handler->display->display_options['title'] = 'My Favorite Merchants';
$handler->display->display_options['use_ajax'] = TRUE;
$handler->display->display_options['access']['type'] = 'perm';
$handler->display->display_options['cache']['type'] = 'none';
$handler->display->display_options['query']['type'] = 'views_query';
$handler->display->display_options['query']['options']['query_comment'] = FALSE;
$handler->display->display_options['exposed_form']['type'] = 'basic';
$handler->display->display_options['pager']['type'] = 'full';
$handler->display->display_options['pager']['options']['items_per_page'] = '5';
$handler->display->display_options['style_plugin'] = 'draggabletable';
$handler->display->display_options['style_options']['columns'] = array(
'title' => 'title',
'value0' => 'value0',
);
$handler->display->display_options['style_options']['default'] = -1;
$handler->display->display_options['style_options']['info'] = array(
'title' => array(
'sortable' => 0,
'default_sort_order' => 'asc',
'align' => '',
'separator' => '',
),
'value0' => array(
'sortable' => 0,
'default_sort_order' => 'asc',
'align' => '',
'separator' => '',
),
);
$handler->display->display_options['style_options']['override'] = 1;
$handler->display->display_options['style_options']['sticky'] = 0;
$handler->display->display_options['style_options']['empty_table'] = 0;
$handler->display->display_options['style_options']['tabledrag_order'] = array(
'field' => 'value0',
'handler' => 'native',
);
$handler->display->display_options['style_options']['tabledrag_order_visible'] = array(
'visible' => 0,
);
$handler->display->display_options['style_options']['tabledrag_hierarchy'] = array(
'field' => 'none',
'handler' => 'native',
);
$handler->display->display_options['style_options']['tabledrag_hierarchy_visible'] = array(
'visible' => 0,
);
$handler->display->display_options['style_options']['draggableviews_depth_limit'] = '0';
$handler->display->display_options['style_options']['tabledrag_expand'] = array(
'expand_links' => 0,
'collapsed' => 0,
'by_uid' => 0,
);
$handler->display->display_options['style_options']['draggableviews_extensions'] = array(
'extension_top' => '3',
'extension_bottom' => '3',
);
$handler->display->display_options['style_options']['tabledrag_lock'] = array(
'lock' => 0,
);
$handler->display->display_options['style_options']['draggableviews_default_on_top'] = '1';
$handler->display->display_options['style_options']['draggableviews_arguments'] = array(
'use_args' => 0,
);
/* No results behavior: Global: Text area */
$handler->display->display_options['empty']['area']['id'] = 'area';
$handler->display->display_options['empty']['area']['table'] = 'views';
$handler->display->display_options['empty']['area']['field'] = 'area';
$handler->display->display_options['empty']['area']['empty'] = FALSE;
$handler->display->display_options['empty']['area']['content'] = 'Start a list of your favorite merchants.

Nulla fringilla, orci ac euismod semper, magna diam porttitor mauris, quis sollicitudin sapien justo in libero. Vestibulum mollis mauris enim. Morbi euismod magna ac lorem rutrum elementum. Donec viverra auctor lobortis.';
$handler->display->display_options['empty']['area']['format'] = 'filtered_html';
$handler->display->display_options['empty']['area']['tokenize'] = 0;
/* Relationship: Flags: favorite */
$handler->display->display_options['relationships']['flag_content_rel']['id'] = 'flag_content_rel';
$handler->display->display_options['relationships']['flag_content_rel']['table'] = 'node';
$handler->display->display_options['relationships']['flag_content_rel']['field'] = 'flag_content_rel';
$handler->display->display_options['relationships']['flag_content_rel']['flag'] = 'favorite';
/* Field: Global: View result counter */
$handler->display->display_options['fields']['counter']['id'] = 'counter';
$handler->display->display_options['fields']['counter']['table'] = 'views';
$handler->display->display_options['fields']['counter']['field'] = 'counter';
$handler->display->display_options['fields']['counter']['label'] = '';
$handler->display->display_options['fields']['counter']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['counter']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['counter']['alter']['absolute'] = 0;
$handler->display->display_options['fields']['counter']['alter']['external'] = 0;
$handler->display->display_options['fields']['counter']['alter']['replace_spaces'] = 0;
$handler->display->display_options['fields']['counter']['alter']['trim_whitespace'] = 0;
$handler->display->display_options['fields']['counter']['alter']['nl2br'] = 0;
$handler->display->display_options['fields']['counter']['alter']['word_boundary'] = 1;
$handler->display->display_options['fields']['counter']['alter']['ellipsis'] = 1;
$handler->display->display_options['fields']['counter']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['counter']['alter']['trim'] = 0;
$handler->display->display_options['fields']['counter']['alter']['html'] = 0;
$handler->display->display_options['fields']['counter']['element_label_colon'] = FALSE;
$handler->display->display_options['fields']['counter']['element_default_classes'] = 1;
$handler->display->display_options['fields']['counter']['hide_empty'] = 0;
$handler->display->display_options['fields']['counter']['empty_zero'] = 0;
$handler->display->display_options['fields']['counter']['hide_alter_empty'] = 0;
$handler->display->display_options['fields']['counter']['counter_start'] = '1';
/* Field: Content: Title */
$handler->display->display_options['fields']['title']['id'] = 'title';
$handler->display->display_options['fields']['title']['table'] = 'node';
$handler->display->display_options['fields']['title']['field'] = 'title';
$handler->display->display_options['fields']['title']['label'] = '';
$handler->display->display_options['fields']['title']['exclude'] = TRUE;
$handler->display->display_options['fields']['title']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['title']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['title']['alter']['absolute'] = 0;
$handler->display->display_options['fields']['title']['alter']['external'] = 0;
$handler->display->display_options['fields']['title']['alter']['replace_spaces'] = 0;
$handler->display->display_options['fields']['title']['alter']['trim_whitespace'] = 0;
$handler->display->display_options['fields']['title']['alter']['nl2br'] = 0;
$handler->display->display_options['fields']['title']['alter']['word_boundary'] = 0;
$handler->display->display_options['fields']['title']['alter']['ellipsis'] = 0;
$handler->display->display_options['fields']['title']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['title']['alter']['trim'] = 0;
$handler->display->display_options['fields']['title']['alter']['html'] = 0;
$handler->display->display_options['fields']['title']['element_label_colon'] = FALSE;
$handler->display->display_options['fields']['title']['element_default_classes'] = 1;
$handler->display->display_options['fields']['title']['hide_empty'] = 0;
$handler->display->display_options['fields']['title']['empty_zero'] = 0;
$handler->display->display_options['fields']['title']['hide_alter_empty'] = 0;
$handler->display->display_options['fields']['title']['link_to_node'] = 1;
/* Field: Flags: Flag link */
$handler->display->display_options['fields']['ops']['id'] = 'ops';
$handler->display->display_options['fields']['ops']['table'] = 'flag_content';
$handler->display->display_options['fields']['ops']['field'] = 'ops';
$handler->display->display_options['fields']['ops']['relationship'] = 'flag_content_rel';
$handler->display->display_options['fields']['ops']['label'] = '';
$handler->display->display_options['fields']['ops']['alter']['alter_text'] = 1;
$handler->display->display_options['fields']['ops']['alter']['text'] = '[title] [ops]';
$handler->display->display_options['fields']['ops']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['ops']['alter']['absolute'] = 0;
$handler->display->display_options['fields']['ops']['alter']['external'] = 0;
$handler->display->display_options['fields']['ops']['alter']['replace_spaces'] = 0;
$handler->display->display_options['fields']['ops']['alter']['trim_whitespace'] = 0;
$handler->display->display_options['fields']['ops']['alter']['nl2br'] = 0;
$handler->display->display_options['fields']['ops']['alter']['word_boundary'] = 1;
$handler->display->display_options['fields']['ops']['alter']['ellipsis'] = 1;
$handler->display->display_options['fields']['ops']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['ops']['alter']['trim'] = 0;
$handler->display->display_options['fields']['ops']['alter']['html'] = 0;
$handler->display->display_options['fields']['ops']['element_label_colon'] = FALSE;
$handler->display->display_options['fields']['ops']['element_default_classes'] = 1;
$handler->display->display_options['fields']['ops']['hide_empty'] = 0;
$handler->display->display_options['fields']['ops']['empty_zero'] = 0;
$handler->display->display_options['fields']['ops']['hide_alter_empty'] = 0;
/* Field: DraggableViews: Order */
$handler->display->display_options['fields']['value0']['id'] = 'value0';
$handler->display->display_options['fields']['value0']['table'] = 'draggableviews_structure_node0';
$handler->display->display_options['fields']['value0']['field'] = 'value0';
$handler->display->display_options['fields']['value0']['label'] = '';
$handler->display->display_options['fields']['value0']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['value0']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['value0']['alter']['absolute'] = 0;
$handler->display->display_options['fields']['value0']['alter']['external'] = 0;
$handler->display->display_options['fields']['value0']['alter']['replace_spaces'] = 0;
$handler->display->display_options['fields']['value0']['alter']['trim_whitespace'] = 0;
$handler->display->display_options['fields']['value0']['alter']['nl2br'] = 0;
$handler->display->display_options['fields']['value0']['alter']['word_boundary'] = 1;
$handler->display->display_options['fields']['value0']['alter']['ellipsis'] = 1;
$handler->display->display_options['fields']['value0']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['value0']['alter']['trim'] = 0;
$handler->display->display_options['fields']['value0']['alter']['html'] = 0;
$handler->display->display_options['fields']['value0']['element_label_colon'] = FALSE;
$handler->display->display_options['fields']['value0']['element_default_classes'] = 1;
$handler->display->display_options['fields']['value0']['hide_empty'] = 0;
$handler->display->display_options['fields']['value0']['empty_zero'] = 0;
$handler->display->display_options['fields']['value0']['hide_alter_empty'] = 0;
/* Sort criterion: DraggableViews: Order */
$handler->display->display_options['sorts']['value0']['id'] = 'value0';
$handler->display->display_options['sorts']['value0']['table'] = 'draggableviews_structure_node0';
$handler->display->display_options['sorts']['value0']['field'] = 'value0';
/* Filter criterion: Content: Published */
$handler->display->display_options['filters']['status']['id'] = 'status';
$handler->display->display_options['filters']['status']['table'] = 'node';
$handler->display->display_options['filters']['status']['field'] = 'status';
$handler->display->display_options['filters']['status']['value'] = 1;
$handler->display->display_options['filters']['status']['group'] = 0;
$handler->display->display_options['filters']['status']['expose']['operator'] = FALSE;
/* Filter criterion: Content: Type */
$handler->display->display_options['filters']['type']['id'] = 'type';
$handler->display->display_options['filters']['type']['table'] = 'node';
$handler->display->display_options['filters']['type']['field'] = 'type';
$handler->display->display_options['filters']['type']['value'] = array(
'merchant_location' => 'merchant_location',
);

/* Display: Block */
$handler = $view->new_display('block', 'Block', 'block');

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Fixed

Please open a new issue as port of draggable views, as it seems to be a bug of that module.

Anonymous’s picture

Anonymous (not verified) commented

You're right, I should have tested it on another view to begin with. The issue has been moved.

Thanks,

Drew

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.