Download & Extend
Comment notify » Issues

html tags in !node_teaser and other variables.

Posted by DREAMER_ES on October 2, 2009 at 8:00am
Project:Comment notify
Version:5.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

comment_notify doesn't checks that the node teaser or other variables don't contain HTML tags even if it sends the mail using plain text.

Applying drupal_html_to_text() to the variables that can contain HTML, as suggested in other bug reports in the matter, fixes the issue.

AttachmentSize
comment_notify.module.patch2.07 KB
Login or register to post comments

Comments

#1

Posted by greggles on October 2, 2009 at 4:07pm

I marked #417396: Sends html tags in email as a duplicate of this. The patch no longer applies and I think ignored the need to render the content before stripping tags (what if people use a input format filter?).

Here's an alternate patch against the HEAD branch (i.e. 6.x-1.x-dev) which I think provides these features a bit more properly but which hasn't been tested thoroughly. Any testers?

#2

Posted by greggles on October 2, 2009 at 4:08pm
Status:patch (to be ported)» needs review

Oh, also, "to be ported" is for situations where the patch has been applied to 6.x-1.x-dev and needs to be ported (rewritten a bit) before it can be committed to 5.x-1.x-dev (both version numbers are examples). So, this is in "needs review" status.

#3

Posted by rapsli on October 20, 2009 at 9:50am
Status:needs review» reviewed & tested by the community

works fine for me.
Tested it on the latest stable version 6.x-1.2

I mean, there's not that much that can go wrong with this patch ;)

#4

Posted by greggles on October 20, 2009 at 2:50pm
Assigned to:DREAMER_ES» greggles
Status:reviewed & tested by the community» needs review

Actually that last patch doesn't commit any more and I seem to have failed to upload my own patch...

AttachmentSize
593958_html_to_text_comment_notify.patch 2.62 KB

#5

Posted by greggles on October 20, 2009 at 10:08pm
Status:needs review» patch (to be ported)

Now committed to 6.x http://drupal.org/cvs?commit=277482

#6

Posted by greggles on October 20, 2009 at 10:09pm
Version:7.x-1.x-dev» 5.x-2.x-dev

#7

Posted by greggles on November 7, 2009 at 12:58am
Assigned to:greggles» Anonymous

To be ported, but not by me.

#8

Posted by greggles on March 10, 2010 at 10:39pm
Status:patch (to be ported)» closed (fixed)

This module is no longer actively developed for Drupal 5. If someone wishes to take over as the 5.x maintainer I would consider it, but these days everyone should really upgrade to Drupal 6.x.