html tags in !node_teaser and other variables.
DREAMER_ES - October 2, 2009 - 08:00
| Project: | Comment Notify |
| Version: | 5.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | patch (to be ported) |
Description
comment_notify doesn't checks that the node teaser or other variables don't contain HTML tags even if it sends the mail using plain text.
Applying drupal_html_to_text() to the variables that can contain HTML, as suggested in other bug reports in the matter, fixes the issue.
| Attachment | Size |
|---|---|
| comment_notify.module.patch | 2.07 KB |
#1
I marked #417396: Sends html tags in email as a duplicate of this. The patch no longer applies and I think ignored the need to render the content before stripping tags (what if people use a input format filter?).
Here's an alternate patch against the HEAD branch (i.e. 6.x-1.x-dev) which I think provides these features a bit more properly but which hasn't been tested thoroughly. Any testers?
#2
Oh, also, "to be ported" is for situations where the patch has been applied to 6.x-1.x-dev and needs to be ported (rewritten a bit) before it can be committed to 5.x-1.x-dev (both version numbers are examples). So, this is in "needs review" status.
#3
works fine for me.
Tested it on the latest stable version 6.x-1.2
I mean, there's not that much that can go wrong with this patch ;)
#4
Actually that last patch doesn't commit any more and I seem to have failed to upload my own patch...
#5
Now committed to 6.x http://drupal.org/cvs?commit=277482
#6
#7
To be ported, but not by me.