signup_status_mailer admin settings page broken by signup_status UI cleanup

dww - October 2, 2009 - 16:32
Project:Signup Status
Version:6.x-1.x-dev
Component:Signup status mailer
Category:bug report
Priority:normal
Assigned:dww
Status:closed
Description

#581846: Cleanup the signup_status admin UI and provide status weights broke the site-wide admin settings page for signup_status_mailer since there are no longer tabs at admin/settings/signup_status by default. So, signup_status_mailer has to define the default local task now. This is slightly brittle, since if any other status add-on module wants to do the same, we'll have to revisit this. But, for now, it's a quick fix to get signup_status_mailer working again. ;)

#1

dww - October 2, 2009 - 18:23
Status:active» needs review

Actually, if we inject the default tab stuff via hook_menu_alter() instead of hook_menu(), we can do it conditionally. This way, if other signup_status add-ons want to do the same stuff, they can do the same trick, and we won't get colliding menu items.

AttachmentSize
594344-1.signup_status_mailer_settings_tab.patch 1.56 KB

#2

dww - October 2, 2009 - 22:34
Status:needs review» fixed

Committed to HEAD. Will be out in alpha3 or beta1 or rc1 -- whatever we call the next release. ;)

#3

System Message - October 16, 2009 - 22:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.