Cannot re-assign $this in location_views.module on line 92

I can't replicate this. I have this installed on several sites and do not see this message on any of them. Are you using php4 or php5? What os, version, etc. are you using. Do you see it always on the modules page or just when you enabled it? Anything else you can think of that would help me figure this out would be great.

Thanks.

I suspect I know the problem, but need you to test it. I stupidly created a variable with the name $this which is probably a reserved word creating your error. I meant to change it but did not get it done.

Try the attached patch (which is pretty confusing because it also cleans up all the windows line endings that got into the original file). I changed the variable name to $configured instead of $this on that line and 2 lines above it where the variable is created.

If you can confirm it works, Ankur can commit the change.

I had this problem as well, but the patch given fixed my problem.

Yeah, this is a problem happens presumably with any PHP version 5+ .. I'm using PHP 5.1.1 here. Updating to critical since it totally breaks the admin/modules page -- all you see is a white page with the error.

I couldn't get this patch to apply (the patch is strange; it seems to replace the whole contents of the file?), but indeed replacing $this with $configured in the two places where it appears did the trick.

Setting RTBC under the assumption that the patch not applying is some weird line-ending/Windows drama.

Sorry for the delay in getting back to this, but I've been out of town for several days with no internet access. I just got cvs access and ankur told me to go ahead and commit changes needed, but I have yet to figure out how the cvs system works (and I don't want to monkey around and break something until I get it figured out.) If Ankur gets to this before I do he can go ahead and commit it, otherwise I will do it once I figure out how.

And yes, the patch is a mess because it backs out all the windows line endings that got into the original file. I couldn't find any way to create a patch that doesn't do that, but hopefully it will commit properly. And I will try very hard not to submit files with windows line ending in the future. :-)

No problem @ the Windows line breaks... I forget sometimes myself, too. :)

If you're on Windows, I highly, highly recommend TortoiseCVS. It makes doing day-to-day CVS stuff a breeze. Everything goes into the right-click menu (checkout, update, commit, etc.) and you just use a normal Explorer folder as your workspace.

I went up the same learning curve as you last year, and wrote up a post about it at http://www.planetsoc.com/node/90, which may be of help. Please feel free to contact me via my contact form if you get stuck!

Thanks for your help webchick. Got this all figured out and have committed the changes to HEAD.