Incompatability with CCK fieldsets and multigroups

I have installed Vertical Tabs to try to debug this, and I've found the problem, but I'm afraid this cannot be fixed in Content Multigroups module. Let's see...

Vertical Tabs searches for top level elements in the form that are fieldsets, and if enabled in Content Type settings form, it manages them in the node edit form. Here, Vertical Tabs moves the whole fieldset to a new position in the DOM.

The problem is that the fieldset used by multigroups is wrapped with a div that is necessary for the AHAH processing of the "Add more values" button. While Vertical Tabs moves the fieldset in the DOM, the AHAH wrapper of the multigroup remains in its original position, and this is what is replaced by the AHAH callback, so after the "Add more values" button has been processed, the form ends up with 2 multigroups (the one that was moved by Vertical Tabs to its new position and the one that comes from the AHAH response).

The multigroup module cannot move this wrapper inside the fieldset because both things are part of the same form element. Well, I cannot see a reliable way to do it from content_multigroup_add_more_js().

On the other hand, maybe the Vertical Tabs module could take this into account and process the fieldset wrapper (not the fieldset itself, but its wrapper) when it is related to AHAH stuff?

Moving to the VT queue, as I think this cannot be done in multigroups module. On the other hand, VT would have to move the DOM element used to wrap the fieldset instead of the fieldset itself.

Another thing VT could do is inject its own wrapper to the fieldset during hook_form_alter(), using #prefix and #suffix, and then it could manipulate this DOM element instead of altering the elements owned by other modules, because it is now breaking Content Multigroup, but it could probably break others.

Subscribing

I would really like this functionality with VT and multigroups for my custom node forms. netaustin placed a patch for tabs.module for fieldgroup_tabs to work with multigroups, maybe some of the code can be used as seed for this issue. See here http://drupal.org/node/590386.

Would appreciate it crea if you could share patch or module solution you described above.

Confirming this problem in the latest vertical tabs release and that this still needs to be fixed. Can vertical tabs include official compatibility for multigroups? Thank you!

I don't use CCK Multigroup so it will require someone to submit a patch and others to review it.

Please test and re-confirm using the latest code, 6.x-1.0-beta6.

I just upgraded to the latest release, updated the database and I get the following error Fatal error: Call to undefined function vertical_tabs_fieldsets() in /home/gov/mysite/WWW/mysite.com/sites/all/modules/vt_default/vt_default.module on line 58

That's a problem with the vt_default.module. Please open a new issue at http://drupal.org/project/issues/vt_default

Confirming that duplicate display bug is still there (and my vt-default problem is now fixed in that project-- sorry about the stray issue)

Here is a screen-shot of the cck fieldset (a multigroup) on the edit form. When selecting "Add more values" the fieldset is still rendered a second time on the page and outside the vertical tabs display. What other information can I supply you in order to help?

Can someone type out a list of specific instructions to create this CCK field/multigroup so I can duplicate this?

Go to http://drupal.org/project/cck and select "View all releases." Download cck 6.x-3.x-dev and install it in your Drupal 6 test environment. Download and install the latest vertical tabs module and be sure that it and the content multigroup module are enabled. Create a content type and add a new group for your content type, but choose multigroup instead of the standard group. Add some fields to this multigroup (in my case I'm using only two text fields to test). Then save your content type. Try creating this content type with this multigroup in a vertical tab on the edit form. Click "add another" below the first set of fields, and prang, you should see the duplicated fields on the node edit screen. I hope that helps!

Ah, that's why I was so frustrated trying to figure it out. I use the DRUPAL-6--2 branch of CCK on my dev install. Ok this is not a very high priority since there isn't even a download to use CCK 6.x-3.x yet (have to checkout from CVS).

Ok I've figured out what's going wrong here. The multigroup element has set a $element['#prefix'] and $element['#suffix']

Haha, yeah this needs to be fixed in D7 as well. Things go horribly wrong with #prefix and #suffix. Created a core bug report at #656580: Fields with #prefix and #suffix fail miserably with vertical tabs. Until then, I don't know how to best fix this.

Is there a temporary workaround that will fix this for vertical tabs in Drupal 6? Multigroup (CCK 3.x-dev) is being widely used, as I understand it, and the multiple fields through multigroup are more important than having vertical tabs. I may just have to disable vertical tabs and let my user interface suffer as a result :( Anyway, thanks for looking into this, anyone; I like these vertical tabs.

No, there's no workaround. Its a bug that'll need to be fixed by brighter minds since there is the same problem in core as well.

subscribed. also hoping for a workaround or fix.

subscribing. vertical tabs is awesome, but I am using multigroups. cannot code, but willing to test.

Chris

+1

I have a solution that solved the problem for me when using multigroups with vertical tabs.

I'm posting the patch, but please note that this is only a fix for the issue with multigroups (doesn't fix the more general prefix, suffix problem). Also, note that this is sort of hacky, and is really only a temporary solution.

subscribing

+1

Hacky or not, the patch posted in #31 worked great. Thanks!

Patch at #31 didn't work for me. Subscribing and waiting for #656580: Fields with #prefix and #suffix fail miserably with vertical tabs.

Solved the problem completely. Patch #31 worked like charm for me. Thanks a lot! :-)

I had a problem after upgrading to 6.x-1.0-rc1 where a Standard Group would only display in a vertical tab even through set as "always open" as desired. It was unclear to me which version Patch #31 applied to.
Falling back to 6.x-1.0-beta7 resolved the problem. Vertical tabs does not show as an option which is fine.

Am running into this too :-\

Another issue:

• Edit a content type (admin/content/node-type/post/fields).
• Create a fieldgroup.
• On the content type main edit page (admin/content/node-type/post), set the new fieldgroup to be displayed in a vertical tab.
• Go back to the fieldgroup settings page (admin/content/node-type/post/groups/group_testing).
• The field's "style" will still say "Always open" rather than "Vertical tab".

Subscribing.

Subscribing.

#31 works, but removes padding and vertical tab contents fill all tab, probably manageable with css.

Is it just me, or patch #31 acts wired. I get empty fieldset with no legend above multigroup before clicking on 'Add more items' and proper fieldset with legend after?

Subscribing. Would love to see this fixed & committed.

After installing Vertical Tabs 6x-1.x-dev I applied the patch from #31. It does work. When using multigroups I was able to add the new value; however in edit mode I was presented with 2 instances of the multigroup, one with the new field to add the new value, the other with the group as was before editing. I added the new value, clicked save and it worked. Going back to the view mode the multigroup appeared properly. Other than the confusion that might be caused by the user seeing 2 instances of the multigroup when in edit mode I am happy with the patch.

Having the same issue here. (With the patch in #31 mostly working)

Subscribing, more than 1 year but still no committed path?
I have tested 6.x-1.0-rc1 and 6.x-1.x-dev but still error. Multigroups is very important feature for Drupal.

Patch #31 works for me, fairly well. However, it would be much better for my site if the multigroup wasn't treated as a vertical tab, but as a nested group inside the other vertical tabs.

subscribing

I agree with #49. I would like to put my multigroup in another tab, rather than have it be its own tab.

Problem solved!

I've been testing the CCK patch at #849420: Cumulative Nested Fieldgroup Patches and so far it seems to work beautifully. It lets you put a multigroup inside a standard group, which prevents vertical tabs from messing with it. This also means you could group other fields with the multigroup in that same tab.

Re-rolling so automated patches.make applies patch without hassle.

The patch does not do anything actually.