I'm getting the following for a breadcrumb on the Login page of my site (/user) and on some of the admin screens:

1 / 2 <img src="/sites/all/modules/contrib/admin_menu/images/icon_users.png" width="16" height="15" alt="Current anonymous / authenticated users" title="Current anonymous / authenticated users" />

Steps to reproduce:
1. Install Drupal (I'm using ver 6.14)
2. Install admin menu module (I'm using ver 1.5)
3. Install Custom Breadcrumbs module (I'm using 2.0-Beta 1)
4. Configure Custom Breadcrumbs to "Use the menu structure to set the breadcrumb trail"
5. Go to any of the following URLs on your site:
/admin/user/user
/user (must be logged out)

Result is the displayed breadcrumb is the above HTML rather than the correct path.

The menu_breadcrumb module had (and has fixed) the same issue. See http://drupal.org/node/303247 for more information.

Comments

MGN’s picture

MGN commented

Thanks. This has been reported before #536638: Title Issue Comes and Goes on User Account Links, but I couldn't reproduce it then. I'll try again with your instructions.

detot’s picture

detot commented

same here with lastest dev

MGN’s picture

MGN commented

Yeah, I've been able to confirm it as well.

I've been thinking that custom breadcrumbs could (and probably should) allow more customization of the breadcrumb trail for menu items. Its ok to have a default that just uses the titles from the menu structure. But if that is all that's desired, then the menu_breadcrumb module could be used instead. I think custom breadcrumbs should also allow for a complete redefinition of the breadcrumb.

So I am considering removing the current option to use the menu structure for the breadcrumb trail from the base custom breadcrumbs module, and revise and integrate it with the (optional) custom_breadcrumbsapi module. This will make it easier to provide for the edge cases like that presented by the admin_menu module. Custom_breadcrumbsapi allows other contrib modules to integrate with custom breadcrumbs to provide breadcrumbs for any page provided by a module.I think this will fit better with the menu structure option, since modules often add menu items. Right now it doesn't do this through the menu structure, but perhaps it should.

Any thoughts on this?

shawn_smiley’s picture

shawn_smiley commented

I think that approach makes sense.

I'd like to see something in the API where you can define which menu(s) are used for generating breadcrumbs and that the breadcrumbs default to the menu path unless overridden someplace else.

MGN’s picture

MGN commented
Version: 6.x-2.0-beta1 » 6.x-2.x-dev
Status: Active » Fixed

I've changed my mind on this. Since breadcrumbs for menu items can already be customized by using custom_breadcrumbs_paths, the default menu structure option seems to fit best in the base custom breadcrumbs module, so I am not moving it to custom_breadcrumbsapi.

I've added two new features. Both are accessible on the custom breadcrumbs settings pages. Now you can specify the menus that will be used for generating breadcrumbs by selecting them from a list of all menus. I've added another feature to prevent custom breadcrumbs from modifying the breadcrumb trails on some pages according to their path. I think either of these options will fix the conflict with the admin_menu module.

The new features are in the 6.x-2.x-dev version (and later in 6.x-2.0-beta2 if it resolves this issue) - currently in cvs and in the next dev snapshot. Please test and report back.

shawn_smiley’s picture

shawn_smiley commented

The update in the 2.x-dev version appears to fix this issue.

Thanks for the update!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Macronomicus’s picture

Macronomicus commented

Yay ... thankyou!!