Download & Extend

hook_enable() and hook_disable() are mis-used. Replace with hook_uninstall()

Project:Menu Breadcrumb
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Extracted from #556552: Menu weights, black/white list, and memory of menu selection

I've removed hook_enable() (which was redundant) and hook_disable() (which wasn't really appropriate). I moved the hook_disable() code to hook_uninstall() instead (with added entries for the new 'menu_breadcrumb_menus_filter' and 'menu_breadcrumb_menus').

AttachmentSize
mb_uninstall.patch1.68 KB

Comments

#1

Status:needs review» reviewed & tested by the community

I agree with this, there is no reason to change settings when the module is enabled or disabled.

#2

Status:reviewed & tested by the community» fixed

Thanks, patch accepted.

#3

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here