hook_enable() and hook_disable() are mis-used. Replace with hook_uninstall()
jweowu - October 3, 2009 - 22:33
| Project: | Menu Breadcrumb |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
Extracted from #556552: Menu weights, black/white list, and memory of menu selection
I've removed hook_enable() (which was redundant) and hook_disable() (which wasn't really appropriate). I moved the hook_disable() code to hook_uninstall() instead (with added entries for the new 'menu_breadcrumb_menus_filter' and 'menu_breadcrumb_menus').
| Attachment | Size |
|---|---|
| mb_uninstall.patch | 1.68 KB |
#1
I agree with this, there is no reason to change settings when the module is enabled or disabled.
#2
Thanks, patch accepted.
#3
Automatically closed -- issue fixed for 2 weeks with no activity.