password_confirm fields don't flag error when required and empty [#59526]

A password_confirm field doesn't display an error when the field is required and the password is not supplied by the user. A patch is supplied to fix this problem.

Comment	File	Size	Author
	form.inc.patch.txt	626 bytes	sammys

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

chx CreditAttribution: chx commented 20 April 2006 at 05:24

Have you tried applying this patch , editing a user and not submitting a password? If yes, then it's OK.

Comment #2

sammys CreditAttribution: sammys commented 20 April 2006 at 05:35

Yes. Applying this patch doesn't create an error condition when the field is not required and empty string.

Comment #3

dww

we/he/they

CreditAttribution: dww commented 22 April 2006 at 08:21

yup, without this patch, if i artificially make the password field required on the user/X/edit page, then it happily allows me to leave both fields blank and form.inc considers it valid. once i apply the patch, two empty passwords is no longer considered valid if a password field is marked as required.

@chx: no, the password_confirm field on the user page is *NOT* required, so you can edit the profile without changing the password, even once this patch is applied. i just hacked that to be able to see the bug in action. ;)

definitely RTBC.

-derek