A password_confirm field doesn't display an error when the field is required and the password is not supplied by the user. A patch is supplied to fix this problem.

CommentFileSizeAuthor
form.inc.patch.txt626 bytessammys

Comments

chx’s picture

chx commented

Have you tried applying this patch , editing a user and not submitting a password? If yes, then it's OK.

sammys’s picture

sammys commented

Yes. Applying this patch doesn't create an error condition when the field is not required and empty string.

dww’s picture

dww
we/he/they
commented

+1

yup, without this patch, if i artificially make the password field required on the user/X/edit page, then it happily allows me to leave both fields blank and form.inc considers it valid. once i apply the patch, two empty passwords is no longer considered valid if a password field is marked as required.

@chx: no, the password_confirm field on the user page is *NOT* required, so you can edit the profile without changing the password, even once this patch is applied. i just hacked that to be able to see the bug in action. ;)

definitely RTBC.

-derek

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Reviewed & tested by the community » Fixed

applied

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)