Assign to fields for tasks and tickets

Subscribing, I need to add more fields similar to project manager and project assigned to for my work.

Nicolo'

Hi,
I made some changes in stormtask and stormticket modules, I created a new field "assigned to" like in stormproject module. Also I made a bug fix in stormticket module, the dateapi function wasn't declared.

Whare con I put this changes?

Nicolo'

subscribing

even if it were something as simple as what is available in projects I would be psyched for that.

+1 for having at least the ability for asigning tickets and tasks to team members.

Seconded, i got tasks assignments to team members working with CCK, but more crossover between users and project oriented tasks and tickets out of the box would be great.

Subscribing

@Magnity:
Thanks for the great work. I am ready to test the beta code in my server. I assume the latest code is available here : http://drupal.org/node/253484

@Magnity
I have tested the storm development version in drupal-6.14.

The project manager field is ideal for the projects module. However, it may be nice if the "Assigned to" field is moved to tasks and tickets. In our organisation, projects are never assigned instead we have project membership. The tasks and tickets are assigned to individual team or groups. I can provide more use cases if required.

Please note that I haven't tested the access control and permission system in storm.

#14 it's a great idea.
I implemented these features ("assigned to" for ticket and task) and also I implemented the possibility to send an email to the person assigned.

@Magnity
Great work and many thanks for the quick fix.

I have tested the latest version and did some basic testing. Here are the issues which I found:
1. The task/ticket view page doesn't show the name of the assigned user
2. The "Assigned To" field in tickets/tasks edit should list the members from the organization selected. Currently all the users in the system are listed in the "Assigned To" drop-down.
3. The tasks and tickets list should also show the assigned user
4. "Assigned To" field in projects may be removed(retain it only if somebody has a strong reason)
5. May be nice if the following permissions are added:
5.1 Storm Ticket : can assign ticket to any user
5.2 Storm Ticket : can assign tickets to self
5.3 Storm Task : can assign task to any user
5.4 Storm Task : can assign task to self

It may also be nice if you could explain the "PEOPLE" in the "Assigned To" drop-down. I didn't noticed any change when I assigned the task/ticket to "PEOPLE".

Great, thank you!
4) In my case is important to have the assigned to field for project.

Thanks @magnity, great work. I have immediately implemented the assign features into Storm Dashboard and this allows filtering for assignments on projects, tasks and tickets.

The latest development release also includes comment form alterations for tasks and tickets that allow the change of the status and the assignment of the task or the ticket.

While doing that I faced the problem mentioned in #17 item 2 above: what people should be displayed as possible assignments. Here is what I came up with:

1) If the project is assigned to a person, only that person is listed as an option
2) If the project is assigned to a teram, all team members are listed as options
3) If the project is not assigned to a person or a team, all people that are assigned to the same origanization as the task/ticket, are listed as options
4) In addition, if the project is assigned to a manager, that person is listed as well

After that I look into all teams and only those teams that exclusively contain members that are selected by step 1-4 above, will also be included as possible options.

That made the most sense to me and I hope it helps others as well. Comments of course welcome.

I too agree with the comments posted in #19, especially regarding the values of the "Assigned To" drop-down.

@Magnity, let me comment on your item 2) in #23: I thought too, that all members of the hosting organization should be available for selection but then I thought why should there be a finegrained assignment on a lower level - the project - if we get those people from the organization anyway. That wouldn't make sense.

Therefore, my code provides a list with *all* members of the organization, if the assignment on the project level is not use (project unassigned). But in any other case, the assignment onm the lower level is more important and therefore overwrites that from the organization.

This would actually address scenarios where you work for an organization on several projects where people from that organization not necessarily know about all the projects in their own company.

Now, I've put that all in one function in storm_dashboard and I happily share that with you, if you wanted to. Please feel free to grab it and stick it into Storm and/or modify it to what ever you want to do with it.

@maginity, please find attached the patch for the assignment options. It's a central function in storm.module which is called by the stormticket_form and stormtask_form respectively. I've tested it and it works apart from the organization or project being changed from within the form. If the rest of it is OK we can probably access that in a second step.

This whole function is used in two ways: (1) to create select options for the filters (which needs all teams and persons as well as the two options "all" and "mine") and (2) to create the select options to assign an existing task/ticket to someone (which doesn't need those two options).

Mode (1) works if you do not provide any $organization_nid and mode (2) otherwise. This is also partially described in the function comment above.

@all, next step is to add a filter for "assigned to" to task and ticket. It may be also a good idea to add the possibility to send an email to the person that has been assigned to.

Here my code for the email function (in italian language :) but I can translate it):

// INSERT / UPDATE FUNCTIONS
  function stormticket_insert($node) {
    _stormticket_beforesave($node);
   
   $result = db_query("SELECT * FROM {stormperson} WHERE nid = %d ", $node->assigned_nid);
     if ($data = db_fetch_object($result)) {
        $emailTo = $data->email;
        $name = $data->fullname;
     } 
   
   $result = db_query("SELECT * FROM {url_alias} WHERE src = '%s' ", 'node/'.$node->nid);
     if ($data = db_fetch_object($result)) {
        $url = $data->dst;
     }
     
   //URL for the ticket page
   global $base_url;  
   $url_down = $base_url.'/'.$url;
     
   $result = db_query("SELECT * FROM {node} WHERE nid = %d", $node->nid);
     if ($data = db_fetch_object($result)) {
        $titolo = $data->title;
     }  
     
   //Parameters for the email
     $params = array(
        'name' => $name,
        'url' => $url_down,
        'titolo' => $titolo
      );
 
   //Send the email to '$emailTo' if send_email checkbox is selected
   if($node->send_mail == 'yes' && $emailTo != '') {
        drupal_mail('stormticket', 'assigned_to', $emailTo, language_default(), $params); 
  }

/**
  * Function to send the email
  */
 function stormticket_mail($key, &$message, $params) {
   switch ($key) {
     case 'assigned_to':
       $message['subject'] = t('Assegnamento ticket');
       $message['body'] = t('Ciao ').$params['name'].t('. Ti e\' stato appena assegnato il seguente ticket: ').$params['url']
                         .t(' dal titolo: "').$params['titolo'].t('"');
       break;
       
       case 'assigned_to_update':
       $message['subject'] = t('Aggiornamento ticket');
       $message['body'] = t('Ciao ').$params['name'].t('. Il ticket "').$params['titolo'].t('", a cui sei assegnato e\' stato appena modificato: ').$params['url'];
       break;
    }
  }

I hope that can help you...

Nicolo'

@magnity:
Thanks for fixing the bugs. I have tested it and it looks good. Since the basic features are working, I'm going to implement it on my production instance. This will surely give more feedback from the actual users.

@all:
I really liked to contribute code to drupal and storm module. However, I only have limited exposure to Drupal source code and hence didn't made an attempt. I'm still in the learning process but it's taking too much time due to other priorities. Your help and encouragement is driving me forward.

OK, here is the second part of the patch, please apply *in addition* to the first patch in #26. It reacts to organization and project select changes in the task and ticket add/edit form. There is one cosmetic todo outstanding but I wanted to provide this for your review first before watsing time on that last little piece.

Note: please flush your menu cache after applying this patch because there is a new menu entry to be recognized.

Here is the improved version of the patch. You now only need to apply this one patch to the latest -dev and it now has also the proper optgroup structure in the drop-down.

Can you please help me debug this? When this happens, can you please look into the HTML source and see the values of the wrong select items? Those values should be node-ids of people but I don't know why it's using the numbers instead of their names.

The latest patch includes the modification that we use the $person->fullname if available and if that's empty, then we use $person->name

Are you probably having people with no fullname provided?

@Magnity:
Add this piece of code into "function stormticket_form(&$node)" to control whether the emails are automatically sent out:

$options = array(
    'no' => ('No'),
    'yes' => ('Yes')
  );
  $form['group5']['send_mail'] = array(
    '#type' => 'select',
    '#title' => t('Send an email'),
    '#options' => $options,
    '#default_value' => $node->send_mail,
  );

I can't create a diff file because this extension was implemented into an old storm version.

The code that I posted is good also for project ad task!!

Another important step is to add a filter to choose the "assigned to" person.

This seems really strange and I double-checked the code, not knowning where this is coming from. The fact that your HTML is having 4 optgroups is what should be impossible.

The function storm_get_addignment_options delivers an array of the following structure:

$options = array(
  'none' => '- unassigned -',
  'Teams:' => array(
    '1' => 'name',
    '2' => 'name',
  ),
  'People:' => array(
    '3' => 'name',
    '4' => 'name',
  ),
);

and if there is no team or person, then the sub-arrays for teams or people get removed before returning the options-array.

Each sub-array generates an optgroup in the resulting html, so there can only be two, one or none. So I'm struggling how your html is getting 4 of them.

Is it possible that you check the Firebug-Console and see what the AJAX request is getting as an answer from the server when populating the select box with those values please?

Once we know that, we can determine whether the php code producing the array or the js code transforming that into html, is going wrong.

@Magnity, can you create the new issue for the email extension?
I created by now a module that works with the new storm release! You can find it attached to this post, I'm weating for feedbacks.

Thanks a lot for your work!

I implemented stormmail.zip. First, I had to change the Italian to English, so you might consider keeping those phrases at the top of the module or in a database extension. Second, I had some trouble with drupal_mail (evidently I'm not alone). I wasn't able to debug it per se, but I installed the SMTP module using SLL and it works just fine now. Thanks for stormmail, this was needed.

It might be useful to allow the Email flag to default to Yes instead of No, and to allow the assignment to "stick" on the project/task/ticket. That is, if I select "Yes" on project "X", then any update to project "X" results in an email.

However, as for the rest of this thread, I must be thick. I have trouble following the threads of development interchange, multiple patches, the lack of a link to the development module, etc. I just installed storm-6.x-1.28.tar and it does NOT have the ability to assign a task or ticket to a person. I'm reluctant to install from the CVS repository due mostly to my inexperience with Drupal, but I'm also unclear as to whether the patches in this thread were applied on the test site, to the dev module, or what. Sorry.

The ability to assign tasks and tickets to individuals is mandatory for my company and an integral part of more robust ticketing systems such as RT.

@magnity, your problem creating tasks/tickets is most probably related to #663164: stormproject is an undefined function

@magnity:
The problem in the third para of #43.

@maginity: regarding #47, I was under the impression that you had a problem with Storm as you were saying "...I just installed storm-6.x-1.28.tar and it does NOT have the ability to assign a task or ticket to a person. I'm reluctant to install from the CVS repository due mostly to my inexperience with Drupal, but I'm also unclear as to whether the patches in this thread were applied on the test site, to the dev module, or what. ..." and I thought that #663164: stormproject is an undefined function would be a hint - however, I might have misinterpreted your post.

Attached is another complete patch against the .dev release from this morning. It solves the problem with the null values and also does an additional sanity check, just in case, title was empty too.

@magnity, I'm sorry. I didn't recognize the error in #43.

Your clarification in #51 is OK.

What you should do for furethr testing: use the Storm dev-release from December 31st and the storm_assignment_options_4.patch from #50.

Not sure where this is coming from and it can't be analyzed without having access to the data in the background. Maybe a team with team member zero?

Anyway, I've included another sanity check and remove records with a zero id before delivering it back to the browser.

Excellent news. Thanks @magnity for sorting this whole thing out.

@Magnity
Have you got time to port the view stuff(item #3 in comment #23) into D6? I am trying to understand how views works in D6. I will surely test the latest dev later tonight.

Good work and collaboration on this, thanks @magnity.

I have installed the latest stable version of storm module, but when I create or edit task, the following warning occurs:

warning: array_key_exists() [function.array-key-exists]: The second argument should be either an array or an object in /home/gnuwings/public_html/dev/qcsc/drupal/sites/dev.gnuwings.org/modules/storm/storm.module on line 943.

This warning occurs only if there are no teams configured in storm. I have tried to fix it in the source, but my inexperience in the code made it ugly and I'm not sure whether it's the ideal solution. Can somebody look into this?

I would like to appreciate @Magnity and @jurgenhaas for the addition of wonderful features in storm.

I'm not a coder. Would that patch add the following new feature?
http://drupal.org/node/738842#comment-2702710