Posted by rfay on October 4, 2009 at 5:53am
| Project: | Amazon Module |
| Version: | 7.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | D7CX |
Issue Summary
Drupal 7 port to be planned and designed in this thread. The first comment will be used for an overall design (so it can be edited and maintained).
Comments
#1
List of issues:
AAT port is still not done. Should be it addressed?Possible feature requests:
Figure out what to do when an ASIN drops out of Amazon.com. This causes havoc with updating Amazon nodes.#2
Add D7CX tag
#3
I will be starting on this today or tomorrow.
#4
Here is the first round.
Database stuff works, filters work, amazon media works, search works.
Still to go: the ASIN module and views support (with views 3!)
Review of this stuff is very much welcomed, and testing will be very much welcomed. There are a lot of moving parts here!
Also, if anybody would be willing to write some tests, a test suite would be fantastic. We'd have to figure out how to do it against the Amazon service, but even if it only ran manually and not under the bot it would be a win.
#5
Committed to HEAD: http://drupal.org/cvs?commit=334506
#6
I just started building a d7 site that will depend heavily on this module (or else some non-Drupal PHP library == yuck) so I'll try to contribute as much as I can! I should be able to begin testing within two weeks.
#7
Very cool - I'll look forward to your reviews and patches. I expect to do the CCK part tomorrow, although the Fields API is new territory for me. Are you already competent with that?
#8
Here's another round.
Now:
Fields work
Filters work
Theming mostly works.
Remaining to be done:
Amazon Media module (I set it back to 6.x to prevent its use for now, but it's actually ported)
Theming in general. D7 changes have thrown me for a loop.
Views integration.
If you'd like to take one of these on, we'll split it up into a separate issue.
The dev release is now set to show, so any miles that you can get on this will be much appreciated.
Committed: http://drupal.org/cvs?commit=336220
I think I"m going to take some time off from this now.
#9
So obviously this took me a lot longer than I had hoped :(
I've done some very basic testing of the API and it's looking good. I'm continuing development of my site over the coming weeks. My needs are pretty simple, but I'll be testing the theming and, when it's ready, views integration once my development has reached that stage.
#10
Not sure whether this matters, but should
'preprocess functions' => 'template_preprocess_amazon_item',be
'preprocess functions' => array('template_preprocess_amazon_item'),on amazon.module line 87?
#11
I imagine it should - thanks.
Patches are welcome. I do expect to get back to views, theming, and the amazon_media module this weekend. If you want to take any part of that, let me know.
Probably better to put something like this in a separate bug. It could get lost here.
#12
Here's tonight's contribution.
I did fix the issue in #10.
Views works, but without relationships, which is a drag. #761372: Missing capability to do views relationships with Fields? Missing 'views data' op? is open about this.
I can't really figure out how to get amazon_media module to do what it needs to do theming wise.
And the amazon link/EAN bugs are to be discussed in #761564: Changing a field value in hook_field_validate().
Committed to HEAD: http://drupal.org/cvs?commit=350028
#13
OK, thanks to lots of help from dereine and yched, views relationships now work! Yeah.
I don't really know what to do about amazon_media, which isn't really operational. I think the theming portion of it just needs a rethink. Further work on that will be at #761832: D7 amazon_media module doesn't theme correctly.
Committed to HEAD: http://drupal.org/cvs?commit=350112
This issue is marked fixed!
#15
Automatically closed -- issue fixed for 2 weeks with no activity.