Location of the ARC library

dman - October 5, 2009 - 02:32
Project:Resource Description Framework (RDF)
Version:6.x-1.x-dev
Component:ARC compatibility
Category:feature request
Priority:minor
Assigned:Unassigned
Status:closed
Issue tags:Libraries
Description

Would you consider joining the gang and Support placing the third-party library in /sites/all/libraries?
I'm using ARC also - for XMP extraction of metadata embedded in images - and would like to avoid doubling up on things like this.
I know path_to_arc can easily be hand-configured, but just thought I'd bring this new and popular approach to your attention to try.

#1

dman - October 5, 2009 - 02:33

We have a tag for this!

#2

Dave Reid - November 23, 2009 - 04:09
Status:active» needs review

Two different patches. One takes an optional approach to Libraries API integration and uses it only if the module is enabled. Other approach creates a dependency on the Libraries API module, which I'd encourage and prefer. I'm actually using the dependency version on my production sites and it's much easier to update the module since I don't have to keep the ARC code inside the module's folder.

AttachmentSize
595974-rdf-libraries-D6.patch 911 bytes
595974-rdf-libraries-dependency-D6.patch 1.16 KB

#3

dman - November 23, 2009 - 05:41

Both fine patches.
I'm wondering if - now that the path is configurable - whether that should be a variable or the resolution should take place closer to the include - rather than a constant.
But I guess because of tight loops and all, it's better out there like that. No practical reason NOT to make it so. I just feel funny when I see constants declared from calculated variables. ... just personal style I guess.

I generally prefer the soft approach, rather than yet another requirement (libraries API is still -dev! ), but maybe making libraries API required will speed its uptake - which I'm behind. libraries API is the new 'token.module' - a shoe-in for core.

So ... generally all good. Patches work. Commit either, I say.
I won't RTBC it yet, as there may be opinion still..

#4

scor - December 5, 2009 - 23:58
Status:needs review» fixed

good idea. thanks. http://drupal.org/cvs?commit=298484

#5

System Message - December 20, 2009 - 00:00
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.