Location of the ARC library [#595974]

Comment	File	Size	Author
#2	595974-rdf-libraries-D6.patch	911 bytes	dave reid
#2	595974-rdf-libraries-dependency-D6.patch	1.16 KB	dave reid

Comment #1

dman commented 5 October 2009 at 02:33

Issue tags:

+Libraries

We have a tag for this!

Log in or register to post comments

Comment #2

dave reid

he/him

English

Nebraska USA

commented 23 November 2009 at 04:09

Status:

Active

» Needs review

Status	File	Size
new	595974-rdf-libraries-dependency-D6.patch	1.16 KB
new	595974-rdf-libraries-D6.patch	911 bytes

Two different patches. One takes an optional approach to Libraries API integration and uses it only if the module is enabled. Other approach creates a dependency on the Libraries API module, which I'd encourage and prefer. I'm actually using the dependency version on my production sites and it's much easier to update the module since I don't have to keep the ARC code inside the module's folder.

Log in or register to post comments

Comment #3

dman commented 23 November 2009 at 05:41

Both fine patches.
I'm wondering if - now that the path is configurable - whether that should be a variable or the resolution should take place closer to the include - rather than a constant.
But I guess because of tight loops and all, it's better out there like that. No practical reason NOT to make it so. I just feel funny when I see constants declared from calculated variables. ... just personal style I guess.

I generally prefer the soft approach, rather than yet another requirement (libraries API is still -dev! ), but maybe making libraries API required will speed its uptake - which I'm behind. libraries API is the new 'token.module' - a shoe-in for core.

So ... generally all good. Patches work. Commit either, I say.
I won't RTBC it yet, as there may be opinion still..