I am wondering why there is "display: inline" coded into the style element of the ul.dynamic-persistent-menu-menu tag. The style code was causing problems with my layout -- the height I set for ul.dynamic-persistent-menu-menu in my style sheet wasn't working. I'm sure there is a good reason it's there, I just can't figure out why given my theme/situation. (Please see my included screenshots for what I am seeing.)
I could copy theme_dynamic_persistent_menu() into my template.php file and remove it there, but that's a rather large function to copy only to remove this code.
I think it would be best that there are no styles declared in the HTML as they will always override whatever is in the CSS file. Would you consider putting those style declarations in a separate CSS file bundled with your module so we can override it in our themes?
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | dynamic-persistent-menu.css_.gz | 501 bytes | anoopjohn |
| #1 | 596318-dynamic-persistent-menu-remove-inline-style.patch | 926 bytes | anoopjohn |
| After style="display:inline" from ul.dynamic-persistent-menu-menu | 14.06 KB | capellic | |
| Default behavior | 14.17 KB | capellic |
Comments
Comment #1
anoopjohn commentedAttached please find a patch to remove the inline styles. Also why was it that the li were styled as inline? I have taken out the display:inline from the code and have styled the li as display:block and float:left and they work pretty good. display:block also allows for setting margins, padding etc.
Comment #2
anoopjohn commentedI am also attaching a css stylesheet used to style a menu in the project I was working with. The colors and fonts will have to be changed as per your requirements. Otherwise the css is ready to go.
Comment #3
yrocq commentedFixed in cvs. Thanks !