I was very confused by the need to give a role the ability to admin site configuration to be able to administrate Notification Settings. I do not want to open up my entire site configuration to the people who will be administrating Notifications. A simple change to line 52 to 'access' => user_access('administer notifications'), solved my problem. But I think conceptually, the module should be this way anyway. If it isn't, what's the point of the Administer Notifications permission? A role with that permission can admin half of Notifications, but not all of it.

Comments

jose reyero’s picture

jose reyero commented
Category: bug » support
Status: Active » Closed (won't fix)

This makes some sense, though it would need some more assessment and checks of everything that can be changed in that pages. An example if you use a different permission there, then you need to check_plain any text variable used there everywhere in the module.

So as these are real site-wide settings (that if set wrong can take down your site) we are using the safest permission here.

if anyone can take the work I mention above, feel free to reopen, but for 6.x Only critical bugs for 5.x