Download & Extend
Issues

Remove remnants of theme_node_form()

Posted by sun on October 5, 2009 at 7:23pm
Project:Drupal core
Version:7.x-dev
Component:markup
Category:bug report
Priority:normal
Assigned:sun
Status:closed (fixed)
Issue tags:API clean-up, Needs Documentation

Issue Summary

WTF @ http://api.drupal.org/api/function/theme_node_form/7 ?

AttachmentSizeStatusTest resultOperations
drupal.theme-node-form.patch1.31 KBIdleFailed: 13650 passes, 32 fails, 165 exceptionsView details
Login or register to post comments

Comments

#1

Posted by System Message on October 5, 2009 at 7:45pm
Status:needs review» needs work

The last submitted patch failed testing.

#2

Posted by ksenzee on October 5, 2009 at 8:02pm

Besides the test failures, we also probably need CSS changes per http://drupal.org/node/296918#comment-974303.

#3

Posted by sun on October 6, 2009 at 1:35am
Status:needs work» needs review

- Fixed tests.

- Fixed remnants in CSS.

AttachmentSizeStatusTest resultOperations
drupal.theme-node-form.3.patch2.46 KBIdleFailed: 13649 passes, 32 fails, 10 exceptionsView details

#4

Posted by System Message on October 6, 2009 at 1:55am
Status:needs review» needs work

The last submitted patch failed testing.

#5

Posted by sun on October 6, 2009 at 3:09am
Status:needs work» needs review

This time for real.

AttachmentSizeStatusTest resultOperations
drupal.theme-node-form.5.patch4.1 KBIdleFailed: Failed to apply patch.View details

#6

Posted by System Message on October 9, 2009 at 4:10am
Status:needs review» needs work

The last submitted patch failed testing.

#7

Posted by sun on March 13, 2010 at 6:38pm
Component:node.module» markup
Assigned to:Anonymous» sun
Status:needs work» needs review

Just found this nice little patch again in my filesystem.

AttachmentSizeStatusTest resultOperations
drupal.theme-node-form.7.patch4.14 KBIdlePASSED: [[SimpleTest]]: [MySQL] 18,733 pass(es).View details

#8

Posted by Jacine on March 17, 2010 at 6:36am

Nice one! :D

Did you leave these two out by accident?

.node-form .container-inline .form-text {
  display: inline;
  width: auto;
}
.node-form .attachments fieldset {
  float: none;
  display: block;
}

#9

Posted by sun on March 17, 2010 at 8:04am

Of course not! That was a test to see who'll catch it :P

AttachmentSizeStatusTest resultOperations
drupal.theme-node-form.9.patch4.25 KBIdlePASSED: [[SimpleTest]]: [MySQL] 18,746 pass(es).View details

#10

Posted by Jacine on March 17, 2010 at 8:07am
Status:needs review» reviewed & tested by the community

Haha! Ok, well it's all good now :D

#11

Posted by Dries on March 18, 2010 at 6:50am
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks.

#12

Posted by System Message on April 1, 2010 at 7:00am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#13

Posted by Gábor Hojtsy on April 6, 2010 at 11:50am
Status:closed (fixed)» needs work

This was not documented in http://drupal.org/update/theme/6/7

#14

Posted by sun on April 10, 2010 at 3:23am
Issue tags:+Needs Documentation

.

#15

Posted by jpmckinney on April 15, 2010 at 4:17pm
Issue tags:-DrupalWTF

No longer a WTF.

#16

Posted by sun on April 23, 2010 at 2:09pm
Status:needs work» fixed

Added docs. http://drupal.org/update/theme/6/7#theme-node-form

#17

Posted by System Message on May 7, 2010 at 2:10pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#18

Posted by Dave Reid on May 10, 2010 at 3:22am
Status:closed (fixed)» fixed

FYI this patch left a watchdog message getting triggered on every node edit view because of a missing theme key 'node_form'. Please advise if the patch posted in #775012-13: Theme key watchdog errors on node pages is the correct solution.

#19

Posted by System Message on May 24, 2010 at 3:30am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here