Don't display the css if you can't access the module.

mgifford - October 5, 2009 - 21:41
Project:BAWStats
Version:6.x-1.1
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:needs work
Description

I ran into this first with a css issue. There are so many css files in a drupal site as there is. No need to display more to the user than they can use.

AttachmentSize
bawstats.css_.patch570 bytes

#1

egfrith - November 9, 2009 - 22:49

Thanks for this and sorry for the delay in replying.

In principle, the idea of serving as few CSS files as possible sounds good. However, I'm wondering how this would interact with CSS aggregating, if it's enabled. Is it be possible that the CSS comes through in the aggregated file anyway? Is it be possible for the CSS to be aggregated when an someone without "view site statistics" permission is logged in?

#2

mgifford - November 10, 2009 - 04:03

Ok, you got me there. Not sure how caching css files is managed for logged in users. I'll let you know if I do find out though.

#3

egfrith - November 10, 2009 - 09:35
Status:active» needs work

Great - if it looks like your patch or a modified version of it wouldn't cause problems, I'd be happy to commit it.

#4

egfrith - November 10, 2009 - 09:36

Thanks - if it looks like your patch or a modified version of it wouldn't cause problems, I'd be happy to commit it.

 
 

Drupal is a registered trademark of Dries Buytaert.