It would be more useful if it used the site-wide date format.

Index: modules/uc_bank_transfer/uc_bank_transfer.admin.inc
===================================================================
--- modules/uc_bank_transfer/uc_bank_transfer.admin.inc	(revision 15860)
+++ modules/uc_bank_transfer/uc_bank_transfer.admin.inc	(working copy)
@@ -85,10 +85,9 @@
           ."VALUES (%d, %d)", $form_state['values']['order_id'],
            mktime(12, 0, 0, $form_state['values']['clear_month'], $form_state['values']['clear_day'], $form_state['values']['clear_year']));
 
-  drupal_set_message(t('bank_transfer received, expected clear date of !date.',
-                     array('!date' => $form_state['values']['clear_month'] .'/'
-                                    . $form_state['values']['clear_day'] .'/'
-                                    . $form_state['values']['clear_year'])));
+  drupal_set_message(t('Bank Transfer received, expected clear date of @date.', array(
+    '@date' => format_date(mktime(12, 0, 0, $form_state['values']['clear_month'], $form_state['values']['clear_day'], $form_state['values']['clear_year']), 'medium'),
+  )));
 
   drupal_goto('admin/store/orders/'. $form_state['values']['order_id']);
 }

Comments

xibun’s picture

xibun commented

Good point! Shouldn't be hard-coded. Thanks.

What do you think when we use the Ubercart setting instead? -> uc_date_format_default

xibun’s picture

xibun commented
Status: Active » Fixed

I have now committed a slightly different patch using the Ubercart date format setting instead.

+  drupal_set_message(t('Bank Transfer received, expected clear date of @date.', array(
+    '@date' => date(variable_get('uc_date_format_default', 'm/d/Y'), mktime(12, 0, 0, $form_state['values']['clear_month'], $form_state['values']['clear_day'], $form_state['values']['clear_year'])),
+  )));

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.