Posted by marcus_w on October 6, 2009 at 11:12am
| Project: | iDEAL Pro | Ubercart Payment |
| Version: | 6.x-1.3 |
| Component: | Code |
| Category: | bug report |
| Priority: | minor |
| Assigned: | keesje |
| Status: | closed (fixed) |
Issue Summary
Hey Kees,
Here's your new issue.
When I looked into the logs via admin/reports/dblog for an error regarding my old ticket, I stumbled upon an empty uc_ideal_pro_pay entry. After looking in the Watchdog table, I found the following:
wid: 26113
uid: 1
type: uc_ideal_pro_pay
message: iDeal payment completion attempted for non-existent order.
variables: i:3;
severity: 5
link:
location: http://mysite/cart/checkout/ideal_pro_statreq?trxid=0050000016849681&ec=...
referer:
hostname:
timestamp: 1254762961
Hope this is enough information.
P.S. Really like the module, thanks!
Greets,
Mark.
Comments
#1
Looks like a watchdog call is not properly migrated to D6 standards. Will look into this when I can, thanks for posting.
#2
Hey,
I looked into it and repaired it, I'll create a patch for it.
Also, I created a new feature.
It now is the case that when a customer exits the iDEAL payment site by closing the browser, the order stays at status 'in_checkout'.
I created an updater function which you can run with crontab (or by browsing to it).
It updates all the 'open' ideal orders (status 'in_checkout') and sets the status to 'canceled' or 'payment_received'.
There was a problem though, in the uc_ideal_pro_payment.transaction_id was a too short field (INT(9)). I resetted this to VARCHAR(16), so it also uses the preceding zero's on the transaction ID's.
A problem that now still exists is the 'old' orders which have status 'in_checkout' and a too short transaction_id, so all orders must be set to 'canceled' or updated by hand.
Since I don't yet know how to create patches, I added the edited files right here, I will look into patching soon :-).
Hope to here from you,
Mark
#3
This was fixed a while ago, only for new installs though. You probably run a site with an initial install of an older version of this module?
If someone can post a patch fixing this (table row format) on update hook, please reopen this issue.
#4
Sorry, to fast, will look at your posted code for the other changes.
#5
Feature "check all" on cron is nice.
But in this state code will not be committed.
This fix only applies on "iDEAL connector". Code should probably live in .module, and make use of the already included library files.
Then, shouldn't it be better when this is check is done on hook_cron?
I'm open for suggestions.
Will apply your watchdog fix, last NULL isn't necessary, thanks.
#6
Automatically closed -- issue fixed for 2 weeks with no activity.