flexinode types should live under 'admin/settings/content-types' instead of 'admin/nodes'
ahoeben - April 21, 2006 - 11:06
| Project: | Flexinode |
| Version: | 4.7.x-1.x-dev |
| Component: | User interface |
| Category: | task |
| Priority: | normal |
| Assigned: | ahoeben |
| Status: | needs review |
Description
Currently the pages for adding and editing flexinode content types live under that 'admin/nodes' page. The 'admin/nodes' page lists existing nodes of all content types, not individual node types. The 'admin/settings/content-types' page is a more logical place to define node types.
The patch moves all flexinode content type pages and actions from 'admin/nodes' to 'admin/settings/content-types'.
| Attachment | Size |
|---|---|
| settings_content-types.patch.txt | 8.88 KB |
#1
After applying the patch, you may have to disable and reenable the flexinode module to see the changes
#2
Interesting suggestion, but it seems inconsistent with the type of options that are generally configured via the settings page. I think of generally think of settings as set-it-and-forget-it type of stuff, but I administer my content all the time.
Now, I think it might be useful to have 'content types', 'add content type', and 'search content'--which are all represented as tabs--also come with default menu items under administer->content, but that may be personal preference, and is easily done through the menu UI anyway.
#3
That's my point.
You say you 'administer your content' a lot. That means editing/approving/deleting etc content, right? Not actually changing the types of content you want your users to be able to post.
Setting up a flexinode node-type is something you'ld do once on a production site, and then you leave the flexinode type alone (or you may break existing content).
The patch emphasises exactly this distinction. Apply the patch and see how much sense it makes ;-)
#4
Point taken... I've been in test and deploy mode, so I'm changing the types a lot more than one would on a production site.
#5
Is there interest in me updating this patch to the current state of the art (drupal 4.7.x-1.x)?
#6
#7
Yes. A lot. I just reviewed the patch, and I like it many muchy :)
#8
I'll get cracking then...
#9
I could extend my previous effort and shift things around a bit more.
The following settings could be moved to a 'content type' fieldset in the content type settings on 'admin/settings/content-types/flexinode-N' (the page where you set workflow options etc):
This way, you have all information about a node type in one location. Only flexinode nodetypes would have a content-type fieldset.
I think hook_form_alter is up for the task, but it would take a little while before I could do it and test it fully.
#10
I won't mind making it a two-phased change either. But, in fact, I'd like to see even the fields management under /admin/settings/content-types/flexinode-N. But that is for later. Lets do it one a time ;)
#11
Step 1
The attached patch is an update to my original patch for the new flexinode_admin.module. Moves flexinode content-type creation and editing to admin/settings/content-types/...
#12
Before moving on to integrating the 'edit content types' tab into the content type settings pages, this issue needs to be resolved. Agreed?
#13
Agreed. I will review that patch soon.
#14
I seem to have it nicked; all flexinode content-type settings under the admin/settings/content-types page, along with the normal 'workflow options' etc.
The patch is rather unwieldly though, because my version is against my local copy which has some of my other patches applied too (eg removing the redundant helptext), so I am waiting untill that is resolved
#15
hook_form_alter has a special place in my heart ;-)
#16
The patch. Like I said, it's kind of pervasive, with all the moving about of code to other forms.
I have changed the paths I used in the previous incarnation of the patch, in case CCK devs get jealous and want to do something similar for their custom content types (eg: .../content-types/flexinode/add instead of .../content-types/add)
#17
Content-type options other than the flexinode options are not being saved at the moment. Please stand by while I investigate.
#18
Fixed.
I have been using the patched version on a production site, but could use some reviews.
#19
Whoops. The patch leaves some stray variables in the variable table. Nothing serious, but I will clean it up with a new patch tomorrow.
#20
prevented storing of stray variables in the variable table