$base_url not declared as global before modification.

JimBroad - October 6, 2009 - 18:28
Project:Secure Pages
Version:6.x-1.8
Component:Code
Category:bug report
Priority:critical
Assigned:JimBroad
Status:closed
Description

Looks like a line of code got missed when refactoring...

securepages_redirect() uses it but does not declare it as global, while securepages_boot() declare $base_url as global but does not use it and calls securepages_redirect().

This is likely the cause of many issues I have seen listed( imagecache urls, form #actions etc...) , adding global definition to that function fixed these issues for me.

Will submit patch shortly.

#1

JimBroad - October 6, 2009 - 19:05
Status:active» needs review

Submitting patches for 6.x-1.8 and 6.x-1.x-dev

AttachmentSize
globalbase_url-6.x-1.x-dev.patch 616 bytes
globalbase_url_6.x-1.8.patch 616 bytes

#2

ppcc - October 30, 2009 - 06:26

subscribing

#3

gordon - November 3, 2009 - 05:51
Status:needs review» fixed

Thanks I have fixed this.

#4

System Message - November 17, 2009 - 06:00
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.