max queue length off by one

toniw - October 6, 2009 - 19:16
Project:Nodequeue
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

If I set the max length of a queue to n it will never be allowed to grow larger than n-1.
So if I set the max length to 5 then adding the fifth node will already bump the first node from the queue, limiting the queue to a max of 4 elements.

AttachmentSize
nodequeue-maxlength-offbyone.patch530 bytes

#1

ezra-g - October 6, 2009 - 19:46
Status:active» fixed

You're right -- I changed this function around recently and missed the -1.

Thanks for the attention to -dev and the patch!

Committed.

#2

System Message - October 20, 2009 - 19:50
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.