reverse in admin view breaks drag-n-drop ordering

Thanks for taking the time to do this on a fresh install and for the clear error report. I marked http://drupal.org/node/576380 as a duplicate of this.

Indeed, we'll want to fix this, keeping in mind both the javascript and degradable functionality. We probably want to check whether the save button or the reverse button was clicked when the form is being submitted, and then perform an additional (server-side) reverse of the queue order before sending it to nodequeue_save_subqueue_order.

Glad to see this already being worked on. Discovered the same thing. Fairly simple to work around if you understand what is happening but users are easily confused.

I just discovered this bug as well. The only way to prevent my nodequeues from reversing their order constantly was to turn off "reserve in admin."

Seeing as though that feature is basically broken, shouldn't this be marked critical?

Thats probably because there are 2 nodes. I can reproduce the problem on my part

Hi,

I tested the patch submited above, it works fine for me.

And I have a real need for this feature, so please approve !

Thanks all for the good work.

works, thx

einkahumor.com, you are right: clicking save without doing anything else reverses the nodequeue.

Curious if the maintainer has any interest in fixing this feature? I feel like if it doesn't get fixed soon, I'll submit a patch to remove this functionality entirely. I've now had a client select this feature and the wonder why their site was not functioning properly.

I've made a small addition to axlroach patch, which seems to solve the problem of the queue being reversed when hitting save without doing any rearranging.
Approach is pretty simple. It just checks if the positions have been changed, then only reverses the nodes if positions have changed.

$current_nodes = _nodequeue_dragdrop_get_nodes($queue, $subqueue);
$old_positions = array();

foreach($current_nodes as $node) {
$old_positions[$node->position] = $node->nid;
}

if ($queue->reverse == 1 && $nodes != $old_positions) {
$reverse_nodes = array();
$p = array_keys($nodes);
$v = array_values($nodes);
$v = array_reverse($v);
foreach ($v as $key => $value) {
$reverse_nodes[$p[$key]] = $value;
}
$nodes = $reverse_nodes;
}

@Einkahumor: I don't know how to make a patch file.

There still seems to be a few bugs. If there are only 2 nodes in a queue the rearranging is failing, 3 nodes are fine though.
And if you remove a node from the queue and hit save, it reversed the queue.
So code really still needs work.

@mortenq: http://drupal.org/patch/create

We are also seeing this bug, using the latest stable release.

This is definitely a critical bug. If you want to reverse the normal behaviour of nodequeues, that is, if you want the added node to be added on position one, and push the last one out, you need to enable "Reverse in admin view". So currently there is no way of doing this without opening the door to this bug.

Here is #19's addition to number #10's patch in one patch file.

Works in my test but as to the best method to use I cannot say.

this patch works for me, but there's still issues with 2 items in a queue, not sure why, but doesn't seem to be because of this patch

I am using node queue with content slider, may you guide me how I could resolve the above issue?

Thanks! #30 seems to work, though it has some formatting issues:

-- there should be no tabs or trailing spaces
-- the inline comment should explain the code, rather than linking to this issue
-- the patch should apply to the nodequeue directory, rather than sites/all/modules...

Change status

After a quick review of #32 on the July 11 dev, everything appears to be working great. Awesome work!

We probably need a few more eyes on it, but it looks like we're finally at a solution.

I am running 6.x-2.9 of nodequeue. I have applied the patches provided in #32 and #30, but the problem still persists.

OK, I installed 6.x-2.x-dev, applied patches #30 and #32 to that, and it did not fix the behavior.

I just tried applying both #30 and #32 and indeed that doesn't work. You should ONLY use the patch from #32. Please try that out and tell us if it works.

RTBC?

This worked for me - great work. Thanks.

I tested the patch in #32 with JavaScript enabled and disabled with a queue set to reverse in admin view and without that option enabled. This looks good and is now committed. Thanks, @gnindl! http://drupal.org/cvs?commit=420666

Thanks also to folks who took the time to review this patch. A bit of feedback on reviewing patches: It's helpful to the maintainer and might get your issue fixed quicker if you specify how you tested, in addition to saying that "it works." In this case, it would have been particularly helpful for folks to report whether they had their queues set to be reversed, and whether they tested with JS enabled :).

Question #1: which version is this supposed to be for 7.x or 6.x (why was it changed to 6.x )
Question #2: the above still doesn't work in 7.x for me, any body else has this problem? The problem is that every time I move one nodequeue item in the nodequeue order, and click save, the nodequeue becomes reversed. It happens every time. It looks as though the reverse in admin view, is applied every time you hit save.

This bug still exists in 6.x-2.11 and 6.x-2.x-dev. I tried the #32 patch on the latter. Three out of four hunks failed. Maybe the dev version has changed such that the patch no longer works?