Comments

boombatower’s picture

Assigned: Unassigned » boombatower
Status: Active » Needs review
StatusFileSize
new6.48 KB

Validation of pifr.queue and basic validation pattern/framework.

Needs documentation, test, and other methods validated.

boombatower’s picture

Also need to remove stuff like:

      pifr_debug(t('XML-RPC batch(): missing project data for branch: (b: @identifier; p: @project_identifier).',
                   array('@identifier' => $branch['client_identifier'], '@project_identifier' => $branch['client_identifier'])));

once proper validation is in place.

Status: Needs review » Needs work

The last submitted patch, 597644-xmlrpc-validation.patch, failed testing.

boombatower’s picture

Status: Needs work » Needs review

#1: 597644-xmlrpc-validation.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 597644-xmlrpc-validation.patch, failed testing.

boombatower’s picture

Status: Needs work » Needs review
StatusFileSize
new8.33 KB

Previous patch contained debug code that caused test failure. Removed debug code, added documentation and a few additional error messages.

boombatower’s picture

StatusFileSize
new24.96 KB

Test, and code cleanup.

Status: Needs review » Needs work

The last submitted patch, 597644-xmlrpc-validation.patch, failed testing.

boombatower’s picture

Status: Needs work » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.