Many-to-one filter does not work with float [#597772]

Filters using float data type doesn't work with many-to-one and in_operator filters because it replaces all numerics with %d instead of checking to see if it's a float. Here's my workaround:

-    $placeholder = !empty($this->handler->definition['numeric']) ? '%d' : "'%s'";
+    $placeholder = !empty($this->handler->definition['numeric']) ? (($this->handler->content_field[type] == 'number_float') ? '%f' : '%d') : "'%s'";

Is there a better way to check if the field is a float type instead of numeric? If you can point me at that (or say this works ok) I'll be happy to roll and submit a patch against -dev.

Comments

Comment #1

fearlsgroove commented 7 October 2009 at 01:20

Btw the code in the original post appears in includes/handler.inc.add_filter and handlers/views_handler_filter_many_to_one.add_where

Comment #2

dagmar

Spanish

Argentina

commented 14 December 2009 at 12:58

Version:

6.x-2.x-dev

» 6.x-3.x-dev

I think we should add a new option in the definition of the handler to define if this is integer or not. And then, make this check. This may require review all numeric handlers...