tuthanh [tuthanh]

Please change only the status, when you upload new code; other metadata is not thought to be changed from the applicant.

The jQuery file is already included in Drupal; third-party module doesn't need to include it.

Then, generally speaking, any files that are available from third-party site should not be committed in CVS (there is an exception, but it doesn't seem to apply, in this case).

You forgot the other files that are available from third-party sites. Also, the file LICENSE.txt cannot be committed, and needs to be removed.

1. Some PHP files under the directory menu contain functions that don't respect the namespace.
2. I also notice that the CVS ID of some files reports symphonytheme as the committer. Are you using code developed from somebody else?

1. We do use modules developed by others. We packed them up into a theme which is out-of-the-box, so users donot have to download many modules to run this theme.

   Themes don't come packed with modules, first; then, what would happen if a user already have those modules installed? He would have duplicated files. It would be better to give instructions to the user to install the modules the theme require.

2. Also, I don't see like a good thing to present code that has been taken from modules developed from other people, when you are applying for a CVS account. In this case it is especially true because the code is not just a little part of a module, but I see many files that report a CVS username of somebody else.
   I could get you are good on copying code, but the code doesn't show if you understood how the code needs to be developed.

3. Some PHP files under the directory menu contain functions that don't respect the namespace.

   That is still true; look for the files with extension .php in that directory, and you will see functions that not respect the module namespace.

4. <?php
   // $Id: template.php,v 0.4.0 2009/10/12 22:22:32 symphonythemes Exp $
   ?>
   <?php
   // Initialize Theme Settings
    
   global $theme_key, $theme_path;
   

   The closed PHP tag could cause an error like headers have been already sent; that is the reason Drupal PHP code (I am not talking of PHP templates) doesn't close the PHP tag (see what done in Drupal core modules).

See the previous point #3, which is still valid.

There have not been replies from the OP in the past 7 days. I am marking this report as won't fix.

I tried to have a look, but it's not workable for me. I'm getting none of the styles mentioned

stylesheets[all][] = css/reset.css
stylesheets[all][] = css/grid.css
stylesheets[all][] = css/typography.css
stylesheets[print][] = css/print.css

So it blanked out my site.

Also, due to php conventions, it would be nice if it conformed to PHP strict declarations. The fixes are easy, but make it a pain to look at on a development machine with PHP notices enabled.

notice: Undefined variable: site_html in /Library/WebServer/Documents/drupal6/sites/all/themes/alphorn_0.4.2/templates/overrides/page.tpl.php on line 53.
notice: Undefined variable: result in /Library/WebServer/Documents/drupal6/sites/all/themes/alphorn_0.4.2/menu/menu.class.php on line 103.
notice: Undefined variable: tree in /Library/WebServer/Documents/drupal6/sites/all/themes/alphorn_0.4.2/templates/overrides/page.tpl.php on line 93.
notice: Undefined variable: tabs2 in /Library/WebServer/Documents/drupal6/sites/all/themes/alphorn_0.4.2/templates/overrides/page.tpl.php on line 103.
notice: Undefined variable: tree in /Library/WebServer/Documents/drupal6/sites/all/themes/alphorn_0.4.2/templates/overrides/page.tpl.php on line 115.
notice: Undefined variable: tree in /Library/WebServer/Documents/drupal6/sites/all/themes/alphorn_0.4.2/templates/overrides/page.tpl.php on line 134.
notice: Undefined variable: site_html in /Library/WebServer/Documents/drupal6/sites/all/themes/alphorn_0.4.2/templates/overrides/page.tpl.php on line 229.

I can see an interesting amount of work has gone into this thing...

Why are there a bunch of views templates? Is it meant to be used with a deployed set of 'features' or configs?
Maybe a README would help explain just why there are so many things here.

From a developer POV, I see that default-style.css, green-style.css etc are large files, almost entirely identical to each other.
You'd have found it easier - and it will be less impossible to maintain - if you broke all that layout into main-style.css, and then added the small color overrides conditionally in individual sheets.

Overall, I'm concerned it's trying to do a lot, but the structure is very hard to get to grips with. This doesn't look like something that anyone can take up and modify themselves.
Perhaps some (any) inline documentation may help explain what you are thinking.

Why do you need your own node-story.tpl.php with an unexpected htmlspecialchars_decode() in it ? - this looks like a special-case hack that was just put in to try and solve a problem of your own - but with no explanation. It's sitting there as a landmine for anyone who tries to use it again.

The screenshot looks cute, but as it's unusable for me, I can't be more positive.

@dman: When you want the user to change something, you should change the status to needs work; change the status also when you want the user to at least answer to the question you make.

I am changing the status as per previous comment by dman, which contains valid points.

See the Drupal coding standards to understand how a module code should be written. The code still doesn't respect them, especially the code in the directory menu.

There have not been replies from the OP in the past 7 days. I am marking this report as won't fix.