This patch includes settings form choices for prompt dialog mode (popup/inline), 'prompt only once' option and IE versions to be prompted (IE6 or older, IE7 or older, IE8 or older). The patch was initially written against the alpha1 version (chrome_frame.module,v 1.1 2009/09/23 17:58:35). Just a minute ago realized the version 1.3 which had already settings form with prompt choices.. But I'll anyway see this patch as an enhancement to chrome_frame module since at least the mode (popup/inline) + css definition for inline mode are truly useful.

Attached:
- Patch
- Modified module files

CommentFileSizeAuthor
chrome_frame.tar_.gz3.97 KBtomimikola
chrome_frame-settings-for-display-mode-ie-version-and-prompt-once.patch12.73 KBtomimikola

Comments

robloach’s picture

robloach
he/him
commented
Status: Needs review » Needs work

Seems we're doing a couple things in this patch....

  1. Display mode (inline/popup)
  2. Split menu callback into a different file
  3. Add cookie and use it

I just committed the split: http://drupal.org/cvs?commit=276880 .... Think we just need to update to use the cookie. Do you think we should make a Drupal Cookie module to abstract the cookie usage so a conflict doesn't happen when two different jQuery Cookie plugins are installed?

robloach’s picture

robloach
he/him
commented
Version: 6.x-1.0-alpha1 » 6.x-1.x-dev

What if for this feature, we depended on jQuery Plugins for the use of jQuery Cookie?

robloach’s picture

robloach
he/him
commented

http://drupal.org/project/jquery_cookie

We'd have to port it to 6.

lelizondo’s picture

lelizondo commented
Status: Needs work » Closed (won't fix)

This is really old. The patch is outdated. If anyone is willing to work on this please re-open and create a patch against dev