Couple of issues with order comments

mpaler - October 8, 2009 - 01:39
Project:Ubercart Marketplace
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review
Description

I'm going to try to crack this myself -- but I just thought I should list it here as a bug:

1. Order comments are not being listed in a seller's view of an order (see attached).

/user/xx/selling/fulfill/xx

2. Feature request: It seem to me that when a seller adds a order comment, the store admin should be notified in addition to the buyer.

AttachmentSize
order-comments.png51.95 KB

#1

jbrodbeck - October 8, 2009 - 19:56

mpaler,

When you get some code worked out or a patch, can you please post it here so we can review/commit it? Thanks.

#2

mpaler - October 11, 2009 - 17:50

Hi,

Attached is a patch fixing number 1 above. It also contains the fix for the bug reported here: http://drupal.org/node/556312

It's rolled against the February 12, 2009 release of 6.x-1.x-dev

I'm finding that #2 above is part of a larger issue of communications structure among Store admin/Seller/Buyer and will require a larger restructure. I believe there should be more granular control over comments and to who they get delivered via email notification. For example here's the variety of scenarios:

1. Admins can post a comment with an email notification sent to either buyer only, seller only, or both.
2. Sellers can post a comment with an email notification sent to store admin only, buyer only, or both.
3. Store admin can restricts all communication b/w the seller & buyer.

All comments are tracked and logged for paper trail.

These variations are complicated and apparently beyond the scope of conditional actions and would probably require some amount of new code. I'm going to move the status to code review, but after that we should move it to feature request.

Mike

AttachmentSize
mp_orders.patch 5.01 KB

#3

mpaler - October 11, 2009 - 17:51
Status:active» needs review

changing status for code review.

#4

asak - November 8, 2009 - 10:35

will test in a little bit...

 
 

Drupal is a registered trademark of Dries Buytaert.