Closed (works as designed)
Project:
Ubercart
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
8 Oct 2009 at 09:25 UTC
Updated:
11 Oct 2010 at 21:13 UTC
Jump to comment: Most recent file
Comments
Comment #1
joachim commentedPatch.
This could be more graceful with token replacement for the minimum value (and maybe other stuff like site name, site email, etc).
But this works for now and I'm too pushed for time to go digging for how that stuff is done :/
Comment #2
tr commentedCurrently, the uc_minimum_subtotal_text variable can be changed using Locale or String Overrides, and it can be translated. There is just no UI to change it. The problem with your patch is that the minimum subtotal shown in the message can't be changed except by hardwiring it in. For example, when you first set up a store, uc_minimum_subtotal will be zero, so the uc_minimum_subtotal_text will get set to "The minimum order subtotal for checkout is $0.00", and the amount will *stay* $0.00 even if the uc_minimum_subtotal variable is changed. So the only way to make the message reflect correct value is to explicitly change the message from the admin menu when the minimum subtotal is changed. This makes it impossible for the value to change based on the store's currency, for example. That's in contrast to the way it is now, where the message will always display the proper value because the substitution is done dynamically. In fact, the message variable is never set, so it's never used and can safely be eliminated
If you want to roll a patch to add a token for the minimum subtotal, and to do token replacement on the message text in the admin menu, I'd be willing to try that out and commit the patch if it works.
Comment #3
tr commented