For some reason the test bot does not executed the test included in the RDF patch #493030: RDF #1: core RDF module. I'm creating this separate issue to avoid adding noise to the main RDF issue.

The test bot does not return any error message whatsoever, so without access to the testing server logs it is hard to find what's going wrong. I'm attaching a couple of patches to see how the test bit reacts to it. There are subsets of the RDF patch. They both patch node.test and add an RDF test to it. Let's see if this is one executed. One does not include the other tests in rdf.test and the other does.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

scor’s picture

FileSize
24.92 KB

now trying the last patch which worked.

Status: Needs review » Needs work

The last submitted patch failed testing.

scor’s picture

Status: Needs work » Needs review
FileSize
28.71 KB
26.14 KB

slowly adding more to the working patch: 1) rdf.install and 2) rdf.crud.inc
let's see what the bot says

Status: Needs review » Needs work

The last submitted patch failed testing.

scor’s picture

Status: Needs work » Needs review
FileSize
26.14 KB
27.45 KB

rdf.install seems to be the culprit

Status: Needs review » Needs work

The last submitted patch failed testing.

scor’s picture

Status: Needs work » Needs review
FileSize
25.68 KB
25.67 KB
25.7 KB
26.13 KB

looks like the bot is not digesting the schema. I must be missing something.

Status: Needs review » Needs work

The last submitted patch failed testing.

scor’s picture

Status: Needs work » Needs review
FileSize
26.1 KB
26.06 KB

looks like 'primary key' => array('type', 'bundle'), is the culprit...

Status: Needs review » Needs work

The last submitted patch failed testing.

scor’s picture

Status: Needs work » Needs review
FileSize
26.24 KB
26.21 KB

trying with indexes on the primary key

Status: Needs review » Needs work

The last submitted patch failed testing.

scor’s picture

Status: Needs work » Needs review
FileSize
26.31 KB
26.09 KB
26.1 KB

some more testing.

Status: Needs review » Needs work

The last submitted patch failed testing.

scor’s picture

Status: Needs work » Needs review
FileSize
26.37 KB
26.14 KB
26.14 KB
26.14 KB

the problem comes from the primary key. can't believe this is not causing any trouble on my 2 localhost (Mac OS and ubuntu) and on none of the other developers localhost.

Status: Needs review » Needs work

The last submitted patch failed testing.

scor’s picture

Status: Needs work » Needs review
FileSize
25.67 KB

ok, so this boils to the following:
- the test bot servers do not like a primary key of type PRIMARY KEY ( varchar(255), varchar(128) ) and will return the error: Failed to install HEAD.

  $schema['rdf_mapping'] = array(
    'description' => 'Stores custom RDF mappings for user defined content types or overriden module-defined mappings',
    'fields' => array(
      'type' => array(
        'type' => 'varchar',
        'length' => 255,
        'not null' => TRUE,
        'description' => 'The name of the entity type a mapping applies to (node, user, comment, etc.).',
      ),
      'bundle' => array(
        'type' => 'varchar',
        'length' => 128,
        'not null' => TRUE,
        'description' => 'The name of the bundle a mapping applies to.',
      ),
      [...]
    ),
    'primary key' => array('type', 'bundle'),
  );

- the install will work if the length of type is changed to 128 or 64.
- the patch 24 shows that defining a unique key of array('type', 'bundle') with type=>varchar(255) and bundle=>varchar(128) will lead to the same failure on install, so unique keys seem to be governed by the same rule as the primary key.

I'm attaching the latest RDF patch with the primary key length fix to see if it installs ok.

note 1: all these worked perfectly on all the development setups, so the testing servers must have a restricted mysql configuration. I'd be interested to know what settings in mysql affect this, so that I could tune my local mysql the same way. That have save me so much time...

note 2: some testing servers might be running pgsql? I didn't try this patch on pgsql and I'm not sure how pgsql would have reacted.

Status: Needs review » Needs work

The last submitted patch failed testing.

scor’s picture

Status: Needs work » Needs review
FileSize
32.43 KB

I found the reason why this was working on my localhost and not on the testing servers. The answer is on the Restrictions on InnoDB Tables for MySQL 5.1 which is the version of MySQL I use on both localhosts:

The InnoDB internal maximum key length is 3500 bytes, but MySQL itself restricts this to 3072 bytes.

Since we're using UTF8, it means the maximum key length one can create is 1024 (3 bytes per char in UTF8). This was confirmed by the error PDOException: SQLSTATE[42000]: Syntax error or access violation: 1071 Specified key was too long; max key length is 3072 bytes when creating a key greater than 1024 char.

Drupal 7 requires MySQL 5.0 which implies:

The internal maximum key length is 3500 bytes, but MySQL itself restricts this to 3072 bytes. (1024 bytes for non-64-bit builds before MySQL 5.0.17, and for all builds before 5.0.15.)

Our original schema contained a primary key on ('type', 'bundle') which are respectively varchar(255), varchar(128), summing up to 383 char and exceeding 1024 bytes when multiplied by 3.

I can only conclude the testing servers are running MySQL 5.0.15 or an earlier version.

I've switched the type varchar length to 128 for now until we decide what to do about it.

Status: Needs review » Needs work

The last submitted patch failed testing.

scor’s picture

Status: Needs work » Needs review
FileSize
5.71 KB

this should fix the exceptions.

Status: Needs review » Needs work

The last submitted patch failed testing.

scor’s picture

Status: Needs work » Needs review
FileSize
31.86 KB

oops, wrong patch.

scor’s picture

Status: Needs review » Closed (fixed)

all green and all the RDF tests are executed. great! thank you test bot for your patience...

scor’s picture

Status: Closed (fixed) » Needs review
FileSize
463 bytes
1.71 KB

reopening this temporary issue to test if the new bot can better report this kind of problem. see #600490: Switch entity type column from varchar(255) to varchar(128) for the active issue.

Status: Needs review » Needs work

The last submitted patch failed testing.

scor’s picture

Status: Needs work » Closed (fixed)

Not so much difference between "Failed to install HEAD" and "Detect a Drupal installation failure"...

scor’s picture

Title: Test bot does not execute all tests » Testbot doesn't execute all tests (please ignore this issue)
Version: 7.x-dev » 8.x-dev
Issue summary: View changes
Status: Closed (fixed) » Needs review
FileSize
235.08 KB

reopening to test this patch which currently fails on that main issue. trying variant of the patch here.

scor’s picture

Status: Needs review » Closed (won't fix)
scor’s picture

Title: Testbot doesn't execute all tests (please ignore this issue) » Testbot <script>alert('e')</script> doesn't execute all tests (please ignore this issue)
scor’s picture

Title: Testbot <script>alert('e')</script> doesn't execute all tests (please ignore this issue) » Testbot futzing (please ignore this issue)
Status: Closed (won't fix) » Needs review
FileSize
3.93 KB

Status: Needs review » Needs work

The last submitted patch, 31: 1933638_d_31_drupal8.settings-dev--radical-cleanup.8.patch, failed testing.

sun’s picture

Component: simpletest.module » other
Category: Bug report » Support request
scor’s picture

Status: Needs work » Closed (won't fix)