It is not very clear what exactly is in the {contact} table, but if we use {contact_category} I think that is much better.
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | rename.contact.table-599130.014.patch | 6.97 KB | karschsp |
| #12 | rename.contact.table-599130.012.patch | 6.75 KB | karschsp |
| #8 | 599130-contact-table-rename-D7.patch | 7.37 KB | dave reid |
| #4 | 599130-contact-table-rename-D7.patch | 8.08 KB | dave reid |
| #2 | 599130-contact-table-rename-D7.patch | 7.77 KB | dave reid |
Comments
Comment #1
dave reidPatch attached for review.
Comment #2
dave reidRerolled for latest changes.
Comment #4
dave reidArgh...fixed the exception.
Comment #5
dries commentedIt is not entirely clear what the advantage of this patch is?
Comment #6
dave reidNot really anything besides helping this table document itself. It only stores contact categories, so I thought we should rename it. It's more in the same effort of the recent contact.module cleanups when we changed functions like contact_admin_edit() to contact_category_edit_form_validate(); changing the function names to a more self-documenting name.
Comment #8
dave reidRe-rolled for head.
Comment #10
dave reidToo late for D7.
Comment #11
marcingy commentedThis isn't a bug
Comment #12
karschsp commentedUpdated patch.
Comment #13
marcingy commentedThis is missing an upgrade path which the original patch included
Comment #14
karschsp commentedsorry about that...re-rolled.
Comment #15
andypostRelated issue #1588422: Convert contact categories to configuration system
This could go to config layer so table is not needed anymore
Comment #16
andypostThere's no more contact table. See #1588422: Convert contact categories to configuration system