It is not very clear what exactly is in the {contact} table, but if we use {contact_category} I think that is much better.

Comments

dave reid’s picture

Status: Active » Needs review
StatusFileSize
new8.91 KB

Patch attached for review.

dave reid’s picture

StatusFileSize
new7.77 KB

Rerolled for latest changes.

Status: Needs review » Needs work

The last submitted patch failed testing.

dave reid’s picture

Status: Needs work » Needs review
StatusFileSize
new8.08 KB

Argh...fixed the exception.

dries’s picture

It is not entirely clear what the advantage of this patch is?

dave reid’s picture

Not really anything besides helping this table document itself. It only stores contact categories, so I thought we should rename it. It's more in the same effort of the recent contact.module cleanups when we changed functions like contact_admin_edit() to contact_category_edit_form_validate(); changing the function names to a more self-documenting name.

Status: Needs review » Needs work

The last submitted patch failed testing.

dave reid’s picture

Status: Needs work » Needs review
StatusFileSize
new7.37 KB

Re-rolled for head.

Status: Needs review » Needs work

The last submitted patch failed testing.

dave reid’s picture

Version: 7.x-dev » 8.x-dev

Too late for D7.

marcingy’s picture

Category: bug » task

This isn't a bug

karschsp’s picture

Assigned: dave reid » karschsp
Status: Needs work » Needs review
StatusFileSize
new6.75 KB

Updated patch.

marcingy’s picture

Status: Needs review » Needs work

This is missing an upgrade path which the original patch included

karschsp’s picture

Status: Needs work » Needs review
StatusFileSize
new6.97 KB

sorry about that...re-rolled.

andypost’s picture

Related issue #1588422: Convert contact categories to configuration system

This could go to config layer so table is not needed anymore

andypost’s picture

Status: Needs review » Closed (won't fix)