There are a lot of cleanups to do in contact.module to help bring this up to documentation and conding standards.

CommentFileSizeAuthor
#9 599186-contact-cleanup-D7-2.patch27.43 KBdave reid
#7 599186-contact-cleanup-D7.patch28.3 KBdave reid
#6 599186-contact-cleanup-D7.patch28.3 KBdave reid
#4 599186-contact-cleanup-D7.patch24.77 KBdave reid
#3 599186-contact-cleanup-D7.patch24.76 KBdave reid
#1 599186-contact-cleanup-D7.patch19.02 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
Issue tags: +API change
StatusFileSize
new 599186-contact-cleanup-D7.patch19.02 KB

Just a few things so far...so much to clean up.
- Renames vague functions like contact_admin_categories() and contact_admin_edit() to contact_category_list() and contact_category_edit_form(). Much easier to tell what each function does.
- Simplified the logic in contact_category_edit_form().
- Cleans up contact_load() for simpler code.
- Cleans up message variables in contact_mail().

Status: Needs review » Needs work

The last submitted patch failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Needs review
StatusFileSize
new 599186-contact-cleanup-D7.patch24.76 KB
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 599186-contact-cleanup-D7.patch24.77 KB

Thank god for simpletest. Patch with 100% less stupid mistakes.

Status: Needs review » Needs work

The last submitted patch failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Needs review
StatusFileSize
new 599186-contact-cleanup-D7.patch28.3 KB

ARG. Wrong patch.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 599186-contact-cleanup-D7.patch28.3 KB

Fixed a few spelling errors.

dries’s picture

dries commented 
+++ modules/contact/contact.admin.inc	8 Oct 2009 16:04:08 -0000
@@ -9,28 +9,35 @@
+  // If no categories were found, add a link to create a new category.

No link is added so the comments looks incorrect.

Otherwise this looks like a nice clean-up.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 599186-contact-cleanup-D7-2.patch27.43 KB

Re-rolled for recent commits and removed that comment.

dries’s picture

dries commented
Status: Needs review » Fixed

Committed. Thanks for the reroll.

Status: Fixed » Closed (fixed)
Issue tags: -API change

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +API change

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.