On node/xx/edit, the description fields doesn't get a wysiwyg, but the confirmation message field does.
This means that the redirection is probably broken, as wysiwyg wraps the text in a P tag.

Versions:
Webform 6.x-2.7
Wysiwyg 6.x-2.0

CommentFileSizeAuthor
#17 fixwebform.zip2.85 KBjm.federico
#16 webform-2.patch1019 bytestreksler
#14 webform-1.patch820 bytestreksler

Comments

djalloway’s picture

This is not an issue with Webform, rather, the configuration of your site.

You have two options to resolve this:

  1. Configure your WYWIWYG to not use an Editor on that specific field.
  2. Disable the WYSIWYG on your Default Input Format, and only use the Editor on a special format, this resolves most WYWIWYG related issues with Text Areas.
djalloway’s picture

Category: bug » support
joachim’s picture

Category: support » bug

You've not addressed the matter of the wysiwyg missing on the webform description (which I assume is the node body).
So that can't be fixed with configuration anyway.

And generally, I disagree.
This is two out-of the-box modules not playing ball together. That shouldn't happen, and it shouldn't require configuration.

It may be up to Wysiwyg to know how to handle these two fields: in which case, let's move this issue to wysiwyg module.
Or webform is doing weird stuff with the node body form, which certainly seems that way to me, as there is one input format selector on two text fields.

djalloway’s picture

You are correct that Webform in your specific version is doing some weird stuff to the node body.
This has been addressed and resolved in the the upcoming release of Webform 3.x (currently under heavy development).

The Wysiwyg module does not allow for specific specification of what Text Areas should or should not get an Editor on them, I personally believe that is a feature they should implement as it would resolve a lot of trouble people have with this.
That is why I responded originally like I did.

But the main point I want to make though is that the confirmation text-area is intended to have an Editor on it and an Input Format selector, this will always be the case. and for the most part, always result in a broken confirmation, if the Wysiwyg is loaded by default and you want a redirect instead of a confirmation screen. (if the editor is loaded by default for your input format type)

What I do on my client sides to get around this is just create a special input format that does not load the Editor, and toggle that Input Format for the confirmation text-area when I want to do a redirect.

I hope this helps, sorry for the confusion.

djalloway’s picture

Category: bug » support

also, that is way I've toggled the category to Support Request, because this issue has been taken care of in 3.x and I don't want to confuse the people who are working hard on Webform.
my apologies if I sent the wrong message in doing so.

gpk’s picture

So it seems that there is no way (still!!) to get Wysiwyg module 2.x to put an editor in the Description textarea?

BTW this is not a complaint, just a question!! And of course as far as Wysiwyg project is concerned, it's webform's fault, etc. etc. :P

Thanks for any pointers. :)

AlexisWilke’s picture

gpk,

I use FCKeditor and it works just fine. Maybe it's time for a change?

Thank you.
Alexis

quicksketch’s picture

So it seems that there is no way (still!!) to get Wysiwyg module 2.x to put an editor in the Description textarea?

It's still not possible in the 2.x branch, and probably won't ever be. This problem has already been fixed in 3.x but by a complete paradigm change in the way Webform operates (all Webform settings are in a separate tab now, they don't even show up on the node form). That said, I still really recommend WYSIWYG module over other solution. It's definitely completely Webform's fault, but the design decision to have only one input format for two fields predated the existence of WYSIWYG module.

gpk’s picture

Thanks for the info Nathan, just what I needed.

Marking as fixed since I think all the questions have been answered now and different solutions (wait for 3.x or use a different editor module) suggested. Might even be possible I guess just to use (F)CKeditor for the problematic webform textarea.

gpk’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

treksler’s picture

Version: 6.x-2.7 » 5.x-2.9
Category: support » bug
Status: Closed (fixed) » Active

We need wysiwyg for the 'description' field in version 5.x-dev. I will look at creating a patch.

quicksketch’s picture

Status: Active » Closed (won't fix)

The Webform 2.x version is no longer supported other than security fixes or critical bugs. I won't be spending time to provide this functionality on 2.x.

treksler’s picture

Priority: Normal » Critical
Status: Closed (won't fix) » Needs review
StatusFileSize
new820 bytes

I see this was marked won't fix.. Well, I will.
How can 2.x be unsupported when 3.x is not even out of beta?

Our entire campus is still on 2.x (hundreds of sites) and we can't upgrade in the foreseeable future. .. IMO this is critical because this used to work with the TinyMCE module and not having an HTML editor in both the 'confirmation' and 'description' fields means webform is broken for many users.

Feel free to close again if you are unwilling to apply this patch, in which case I will just maintain yet another Drupal module in my own SVN, sigh.

The following patch provides a fix for those on 5.x-2.9

quicksketch’s picture

Status: Needs review » Closed (won't fix)

2.x is still maintained, but new features aren't being added. This isn't intended to be a feature I know, it's a fix to make Webform work with WYSIWYG. However it in itself is not actually a bug either, since WYSIWYG is making assumptions about the way that input formats are used relating to text areas. I love WYSIWYG module, but Webform wasn't designed to work with WYSIWYG since Webform 2.x pre-dated the creation of the WYSIWYG project.

The patch you've submitted won't work anyway, since if you have 2 input formats you need to create a new column in the database to store the confirmation_format (say your body is one format and the confirmation is another). Again, it's been fixed in 3.x and if you'd like to use WYSIWYG with Webform then you can upgrade.

treksler’s picture

Category: bug » support
Priority: Critical » Normal
Status: Closed (won't fix) » Closed (fixed)
StatusFileSize
new1019 bytes

Thank you for taking the time to look at the patch.
Good point about actually storing the input formats.
I can see why you would not want to add database columns to 2.x

IMO, exposing the input format selection to people creating nodes doesn't make any sense anyway.
I think this is something that should be set once when creating the content type, and left alone, but that's another discussion.

If anyone else needs absolutely needs the editor to appear for 2.x, here's a patch/hack that simply hides the now broken input format selection, while still making the editor appear for both fields. This is enough of a 'bugfix' for me and my clients... and is hopefully useful to at least someone browsing this issue queue.

jm.federico’s picture

StatusFileSize
new2.85 KB

For those looking for a solution tin D6, install the attached module, it rearranges the way the fields are loaded to set the WYSIWYG editor in the BODY field.

I find this to be a good solution without having to apply patches.

code:

function fixwebform_form_alter(&$form, &$form_state, $form_id){
  switch ($form_id) {
  /**
   * Fix WYSIWYG form position error with webform nodes
   */
    case 'webform_node_form':
      //Re arrange wysiwyg form field to affect only description
      $temp = $form['webform']['settings']['confirmation'];
      unset($form['webform']['settings']['confirmation']);
      $form['webform']['settings']['confirmation'] = $temp;
      break;
  }

Cheers

Federico

harrrrrrr’s picture

#17 fix works on D6