'Fatal error' produced by 'Analyze content for links' button

Same result using the 'Clear link data and analyze content for links' button.

Huh, thanks. Since I'm positive I didn't add the bad PHP myself, I'll have to comb through everything to find the problem. Any chance the offending node gets logged somewhere?

Also, the 'Please continue to the error page' link points back to the "Administer › Site configuration › Link checker" page. Is this supposed to direct me to an actual error page or was I just confused by the link text?

Sorry, hass, that kind of patch is probably beyond my present abilities. I would if I could!

Also, I was hoping a database search for the string "file_read" might help, but nothing whatsoever turned up.

Found it! Thanks for the SQL help.

Here's the PHP code (modified a bit to be more 'exampleish') from the node in question:

<?

	$arrClassifcations['loremipsum1'] = 'Lorem ipsum 1';
	$arrClassifcations['loremipsum2'] = 'Lorem ipsum 2';
	$arrClassifcations['loremipsum3'] = 'Lorem ipsum 3';
	$arrClassifcations['loremipsum4'] = 'Lorem ipsum 4';

	$rows = 25;
	$cols = 19;

	$arrTerms[2009]['summer'] = "Summer 2009";
	$year = ( isset($arrTerms[$_REQUEST['year']]) ) ? $_REQUEST['year'] : 2009;
	$term = ( isset($arrTerms[$year][$_REQUEST['timeperiod']]) ) ? $_REQUEST['timeperiod'] : 'summer';

	$is_valid = ( isset($_REQUEST['type']) );
	$is_valid = ( $is_valid && array_key_exists($_REQUEST['type'], $arrClassifcations) );
	$is_valid = ( $is_valid && $_REQUEST['lorem'] >= 0 && $_REQUEST['lorem'] < $cols );
	$is_valid = ( $is_valid && $_REQUEST['ipsum'] >= 0 && $_REQUEST['ipsum'] < $rows );

	function file_read_csv($file, $delim=',') {
		if ( ($arrFile = file($file)) === false ) return false;
		$arr = array();
		foreach ($arrFile as $line) {
			$arr[] = explode($delim, $line);
		}
		return $arr;
	}

	if ($is_valid) {
		$arrData = file_read_csv("/examplepath/{$term}_{$_REQUEST['type']}.csv");
		$rate = '$'.number_format($arrData[$_REQUEST['ipsum']][$_REQUEST['lorem']]);
	} else {
		$rate = '?';
	}

?>

This was old even when I first inherited it and I'm not surprised to hear that it may have issues. However, as you can see the file_read_csv function is used only once, and then it is referenced a few lines down in an if statement. Is that what you meant by "duplicate function"?

Yes, sorry hass, you must have posted #9 as I was nuking and revising #8. :)

Oh, now I understand the duplication reference. This code was scheduled to be integrated into template.php but it hadn't been done yet. You are totally correct about that being best practice.

Guess you can close out the issue now. Thanks for the help.

Hass,

Thanks again for your help earlier. It appears that even after temporarily removing the offending node, the fatal error is still triggered by those buttons.

Even worse, I could not even save node changes today, all of a sudden. No error was produced by that, but the scanner popped up automatically, did its thing, and then took me back to the node/edit page each time.

To remedy, first I tried unpublishing the node containing the file_read_csv code, but the problem remained - couldn't edit and the analyze buttons still failed in the same way.

An error has occurred.
Please continue to the error page

An error occurred. /batch?id=83&op=do <br /> <b>Fatal error</b>: Cannot redeclare get_file_array() (previously declared in /DRUPALPATH/includes/common.inc(1645) : eval()'d code:18) in <b>/DRUPALPATH/includes/common.inc(1645) : eval()'d code</b> on line <b>27</b><br /> 

Next I removed all contents from the node and cleared the site cache. No change to the problem.

Next I disabled Link checker, and was now able to save the edited node I wasn't able to save earlier. But when I re-enable Link checker, these issues remain.

Ah, gotcha. Should have noticed that.

Strange that this is only starting to happen this week, when these nodes have existed for six months and Link Checker has been running for two months. I suppose it must not have progressed far enough in its scans until now.

Thanks again.

Hass,

I realize this extends somewhat outside the scope of this module, so apologies in advance if this is starting to get annoying.

Template.php is tied up at the moment due to various project-related factors and complications, and it's simpler to rename the two functions for the time being. I renamed the functions to node_45_file_read_csv and node_93_get_file_array respectively. The nodes are working fine individually, but the following appears when I run the scanner from the Broken Links admin page:

An error has occurred.
Please continue to the error page

An error occurred. /batch?id=88&op=do <br /> <b>Fatal error</b>: Cannot redeclare node_93_get_file_array() (previously declared in /DRUPALPATH/includes/common.inc(1645) : eval()'d code:18) in <b>/DRUPALPATH/includes/common.inc(1645) : eval()'d code</b> on line <b>27</b><br /> 

Why might this function show up as redeclared? I'm positive it is unique.

You mean to help debug the "redeclared-but-not-really-redeclared" function, or to prevent people from putting PHP in my nodes? I am interested in working around the issue by renaming functions on a case by case basis. I can't take drastic action with regards to PHP in nodes just yet.

Thanks again.

Oh wait, you were referring to linkchecker 6.x-2.x-dev. I thought you meant devel. Not sure what you meant by disabling the PHP filter, though.

Right, now I'm with you, and I agree 100%. Will give that a shot soon.