Posted by Jason Ruyle on October 8, 2009 at 7:08pm
| Project: | Theme developer |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Jason Ruyle |
| Status: | closed (duplicate) |
Issue Summary
Not sure if this has been fixed, but in the 6.x-1.8 version I was having issues with the span tag breaking my apachesolr links.
Attached is a patch to fix.
| Attachment | Size |
|---|---|
| devel_themer_nl2br.patch | 470 bytes |
Comments
#1
meant to have it be 18 not 8
#2
This patch doesn't work :)
warning: Wrong parameter count for nl2br() in .../sites/all/modules/devel/devel_themer.module on line 507.
devel_theme_call_marker function has to return an array with to fields: Line 235 list($prefix, $suffix) = devel_theme_call_marker
nl2br() doesn't return an array and just let this term be true: if ($start_return != $start_prefix ...
#3
#4
Yeah, the use of spans does cause a bunch of problems, and fixing it isn't a small task. There's an issue for it: #425716: Use comments instead of spans to markup theme calls, which will hopefully see some energy put into it.
In the meantime, people get around it by having "Theme developer" disabled most of the time, and only enabling it when needing to do something specific: there's a handy "Disable/Enable Theme developer" link in the "Development" block provided by the devel module to do just that.
#5
I have got last dev version of devel & devel_themer and there is no "Disable/Enable Theme developer" link in Development" block! WTF? :>
#6
+ screenshot [logged as user uid 1 with permissions]
#7
This appears to be a side issue of spinning off devel_themer into its own module.