I tried the latest version of this theme - on my drupal installation no images where shown on the page, cause i unpacked the theme to path not corresponding to the /sites/all/themes..

I changed the pathes in the style.css to relative ones and everthing was working fine for me..
Attached to this Posting you'll find a patch for style.css ..

CommentFileSizeAuthor
#4 style.patch11.56 KBsteffenr
#2 style.patch12.57 KBsteffenr
style.patch13 KBsteffenr

Comments

dman’s picture

dman commented

Good start, but

-  background: url("/sites/all/themes/sports/icon-images/text-html.png") no-repeat right;
+  background: url("/sites/dev.port11.de/themes/sports/icon-images/text-html.png") no-repeat right;
...

o_O ?

You don't really need the ./ either, when just images/... will work.

steffenr’s picture

steffenr
Primary language German
Location Bremen
commented
StatusFileSize
new style.patch12.57 KB

oh - that's right.. i changed it and attached an updated patch file.

dman’s picture

dman commented

The joys of search & replace :-B

-The HTML markup for this Drupal page is appalling
+The HTML markup for this Drupal page is appdev.port11.deing

!!

... I have nothing to do with the theme, just a free review ;-)

steffenr’s picture

steffenr
Primary language German
Location Bremen
commented
StatusFileSize
new style.patch11.56 KB

You're right search & replace can be really annoying - i just wanted to create a quick patch on the style.css and i hope it'll end up with the last patch file i'm posting here.. I downloaded the original theme again, changed the pathes - now i hope the patch will work as noticed ..

Thanks for your patience - it's the first patch "in my live" - and i'll be more careful next time ;)..

dman’s picture

dman commented
Status: Active » Reviewed & tested by the community

it's the first patch "in my live"

... I could tell ;-)
Just wanted to give you some friendly encouragement, because it's mostly right! And useful.
I'm not actually testing, but thought I'd be able to point out a few 'gotchas'. So now we know...
Looks good about now!

AndyW’s picture

AndyW commented

Okay thanks I'll deal with it. :)

AndyW’s picture

AndyW commented
Status: Reviewed & tested by the community » Closed (fixed)