Please find attached a patch for Ubercart rc7 that fixes the following:
- address dropdown should now always be populated on the checkout form
- fix for null phone number field resulting in a JavaScript error in uc_cart.js
- only show address book icon if user has "set own user location" permission
It should probably also be documented somewhere that in order for users to actually be able to edit their addresses, the "Maximum number of locations" setting at /admin/user/settings must be changed to something other than 0. The module does not respect these settings yet either - an unlimited number of addresses will be saved at present.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | uc_location-rc7-1.patch | 1.8 KB | longwave |
| #1 | zero.jpg | 105.98 KB | stefan81 |
| uc_location-rc7.patch | 3.36 KB | longwave |
Comments
Comment #1
stefan81 commentedI tested it briefly and it seems to work so far.
But I found a little issue:
There is a "zero" in the address dropdown at checkout.
(see: zero and space before the postal code in the attached image).
I wonder where that comes from, as the postal code field only contains 8134 in the account.
Comment #2
longwaveUpdated patch against HEAD attached, with the following changes:
- fix for "0" being displayed as zone code if the state/province address field is disabled
- fix for null phone number field resulting in a JavaScript error in uc_cart.js
- only show address book icon if user has "set own user location" permission
Comment #3
stefan81 commentedThank longwave!
Fixed :)
Comment #4
stefan81 commentedComment #5
longwaveSetting correct issue status for you, "fixed" should only be used when the maintainer commits this patch.
Comment #6
bibeksahu commentedThank you. We'll get to this as soon as possible. In the meantime, I've updated the project page to point to this patch.
Comment #7
bibeksahu commentedI've created a new issue to address upgrading to Ubercart 2.0 final: #614382: Ubercart 2.0 Final support
The code in this rc7 patch should address most (hopefully all) of the necessary work. We'll get to it as soon as we can (probably within the next month). Patches or test reports are welcome. I'd love to hear if someone has used this rc7 patch with Ubercart 2.0 final and knows whether it works or not.
Comment #8
mearnest commentedThe patches have been integrated into CVS HEAD.