Beta4 not Working

ddbell - October 9, 2009 - 12:13
Project:Timeline
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

Upgraded to Beta4 and the timeline disappeared. Resaved view the still nothing. Please assist. Thanks.

#1

xamanu - October 9, 2009 - 12:47

Have you cleared your drupal cache? Have you checked on the views settings, if everything is like it should be?

#2

xamanu - October 10, 2009 - 10:39
Status:active» postponed (maintainer needs more info)

#3

SpzToid - October 11, 2009 - 14:19
Component:Configuration» Code
Category:support request» bug report
Assigned to:ddbell» Anonymous

I can confirm as well, that switching to beta 4 displays a GBOD (gray block of death, where the timeline used to be). To clarify, I repeatedly changed between copies of all three module versions (beta 2,3, & 4), clearing all caches each time, with predictable, repeatable results. In fact I was waiting to see if someone else saw this issue, while I reverted back to beta 3 which runs ok.

At least when I was testing as described, I did manage to debug my installation to improve it, and I can run the timeline with local libraries installed in /all/libraries; as well as the similie server. You can private message me for the development address if you want. I can run it in debug mode for you also; otherwise I don't know what else I can report at this time.

The timeline has become a very important component to our non-governmental organization's website, and we'd like to publish it at the bottom of every page; so long as we can cache and distribute everything efficiently enough to be realistic.

#4

klflote - October 14, 2009 - 00:12

Yes, this is trivial to replicate: take a brand-new drupal 6.14 installation, add the views module and the timeline module, create a node, and go to site/timeline/nodes -- GBOD.

The problem seems to be the change on line 53 of Timeline.class.inc -- which sets the 'theme' in the data array.
$this->data['theme'] = drupal_substr(strrchr($view->style_options['display']['appearance']['theme'], '/'), 1);

The problem is that style_options[...] is the string "ClassicTheme" -- it has no slashes in it, so the strrchr gets a NULL return. I changed it back to the original code
$this->data['theme'] = $view->style_options['display']['appearance']['theme'];
and everything worked okay.

#5

ddbell - October 14, 2009 - 14:52

Thanks.

#6

ionchannels - October 14, 2009 - 18:23

Same here - timeline no longer displays.

#7

klflote - October 15, 2009 - 03:00
Status:postponed (maintainer needs more info)» needs work

Here is a proposed patch to fix the issue.

The patch is agains the DRUPAL-6--2-0-BETA-4 tag branch. The bug does not exist in the head; the bug was only introduced in the BETA 4 branch.

The CVS checkin for the beta 4 branch doesn't indicate why the call was changed. I'm guessing that the intent was to get the basename of the theme file, so that's what I put in the patch. The module maintainer will have to sort that out if it is incorrect.

AttachmentSize
timeline-beta4-patch.diff 1.18 KB

#8

ddbell - October 15, 2009 - 15:14

Another problem with BETA 4, the setting to show "first event on timeline" upon opening is not working correctly. I have multiple items on the timeline and it will not default to the first entry on the timeline. Please check.

#9

ddbell - October 15, 2009 - 17:07

Another problem, the timeline balloon goes upward off the page when multiple items appear on the timeline around the same time period. When you click on the timeline item, the balloon appears with content. Most of my balloons have alot of content. If you click on the timeline item when it is on the top of the timeline, the balloon opens on the left or right and the content in the balloon scrolls down the page just fine. However, if you click the timeline item when another timeline item is below the first item, the balloon opens on the left or right and the content in the balloon gets cut off because the balloon sends the content upward off the page. Please fix.

#10

xamanu - October 19, 2009 - 13:56
Version:6.x-2.0-beta4» 6.x-2.x-dev
Priority:normal» critical
Status:needs work» needs review

I think i fixed this error with the lastest commit: #276704

You can test it downloading the latest version of the module's DRUPAL-6--2 branch:
cvs -z6 -d:pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal-contrib checkout -d timeline -r DRUPAL-6--2 contributions/modules/timeline

#11

ddbell - October 19, 2009 - 14:07

Thanks.

#12

xamanu - October 20, 2009 - 09:39

Please mark this bug as "reviewed and tested by the community" if you can confirm that this is fixed now. So I can publish beta5.

#13

klflote - October 20, 2009 - 21:34
Status:needs review» reviewed & tested by the community

I tested this and the bug is fixed. Still a little curious as to what the code is intending and whether the given fix is as brittle as it appears.

#14

klflote - October 20, 2009 - 21:59

Let me clarify -- the bug about it not displaying at all is what I tested and is fixed. ddbell, if you are having other problems, you really need to open separate bugs for them.

#15

ddbell - October 20, 2009 - 22:06

Thanks. This bug is fixed. I am sorry to put two bugs in one issue. I will open another issue for the bug that I am still having a problem with. Thanks for your quick responses.

#16

xamanu - October 24, 2009 - 18:14
Status:reviewed & tested by the community» fixed

Fixed with official 2.0 release.

#17

System Message - November 7, 2009 - 18:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.