Closed (duplicate)
Project:
Scrollable Views
Version:
6.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 Oct 2009 at 22:46 UTC
Updated:
4 Nov 2011 at 10:03 UTC
Sorry I'm not including a patch, however this is a simple fix.
In the function 'theme_scrollable_view', there is an extra comma in this block of code right at the bottom on the 'easing' line.
More forgiving browsers don't have a problem with this, but good ol' IE6 completely breaks over it.
$js = '$(document).ready(function() {
// initialize scrollable
$("div.scrollable").scrollable({
size: '. $options['size'] .',
vertical: '. $options['vertical'] .',
clickable: '. $options['clickable'] .',
loop: '. $options['loop'] .',
interval: '. $options['interval'] .',
speed: '. $options['speed'] .',
keyboard: '. $options['keyboard'] .',
items: ".'. $options['items'] .'",
prev: ".'. $options['prev'] .'",
next: ".'. $options['next'] .'",
prevPage: ".'. $options['prevPage'] .'",
nextPage: ".'. $options['nextPage'] .'",
navi: ".'. $options['navi'] .'",
easing: "'. $options['easing'] .'",
});
});';
The comma at the end of the definition for the 'easing' element needs to be remove. Here is the correct version:
$js = '$(document).ready(function() {
// initialize scrollable
$("div.scrollable").scrollable({
size: '. $options['size'] .',
vertical: '. $options['vertical'] .',
clickable: '. $options['clickable'] .',
loop: '. $options['loop'] .',
interval: '. $options['interval'] .',
speed: '. $options['speed'] .',
keyboard: '. $options['keyboard'] .',
items: ".'. $options['items'] .'",
prev: ".'. $options['prev'] .'",
next: ".'. $options['next'] .'",
prevPage: ".'. $options['prevPage'] .'",
nextPage: ".'. $options['nextPage'] .'",
navi: ".'. $options['navi'] .'",
easing: "'. $options['easing'] .'"
});
});';
Comments
Comment #1
justindodge commentedI should mention the file I'm referring to is scrollable.module
Comment #2
akaserer commentedfirst of all: this module is great
and: yes it modificationworks
just remove the last comma after
easing: "'. $options['easing'] .'",
one way to solve is to add the following to your template.php
replace YORUTHEMENAME !!!
is it possible that somebody creates a patch and commits??
thanks
Comment #3
akaserer commentedduplicate of
http://drupal.org/node/484416
Comment #4
operations commentedHI,
Thanks for solving my problem (extra comma in jquery), I'd like to mention that it was appearing in both IE6, IE7 in my website.
This module is awesome! but I still think that it needs to have a configuration of continuous scrolling (not to go backwards till the first item, instead to display the first beside the last and continue scrolling).
Another thing, is that when a user clicks prev. button it navigates backwards then move again.. so it must pause when a user desires to manually navigate.
Regards,
Comment #5
batje commented