Allow Displays to be disabled

if you have enable the "VIEWS UI module" you have access to your views in the site building part of drupal.
There is a list of your views you can override it or disable/delete it.
If you have created your views with the interface you have to export this views in a module then you will be able to disable the views and not delete it.
For the export you have a tool in "TOOLS" section of view where you can mass export views in a module. it gives you the instructions for create a module.

OUPSS two comments ^^

Will consider this feature for the 3.x branch.

+1 for this feature in the next version

Here is a first version for this feature.

The code links fine beside execute_hook_block and execute_hook_menu

I would like to have this feature much deeper in views. I guess view::set_display would be a place to check for it.

This would a) simplify the code and b) make it more robust.

I'm not sure whether this will work.

Mmm. #8 doesn't work: See attached image.

Ok, this works, as merlinofchaos suggested, check if the display is enabled at build() function is enough to disable a display.

 
+    // Don't allow to use deactivated displays.
+    if (!$this->display[$this->current_display]->handler->get_option('enabled')) {
+      $this->build_info['fail'] = TRUE;
+      return FALSE;
+    }
+

This makes sense. The display plugin takes care to return the right thing if the build failed. For example the page display returns drupal_not_found().

Manual testing worked fine.

$view = new view;
$view->name = 'test_600742';
$view->description = '';
$view->tag = '';
$view->view_php = '';
$view->base_table = 'node';
$view->is_cacheable = FALSE;
$view->api_version = '3.0-alpha1';
$view->disabled = FALSE; /* Edit this to true to make a default view disabled initially */

/* Display: Defaults */
$handler = $view->new_display('default', 'Defaults', 'default');
$handler->display->display_options['access']['type'] = 'none';
$handler->display->display_options['cache']['type'] = 'none';
$handler->display->display_options['query']['type'] = 'views_query';
$handler->display->display_options['exposed_form']['type'] = 'basic';
$handler->display->display_options['pager']['type'] = 'full';
$handler->display->display_options['style_plugin'] = 'default';
$handler->display->display_options['row_plugin'] = 'fields';
/* Field: Node: Nid */
$handler->display->display_options['fields']['nid']['id'] = 'nid';
$handler->display->display_options['fields']['nid']['table'] = 'node';
$handler->display->display_options['fields']['nid']['field'] = 'nid';
$handler->display->display_options['fields']['nid']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['nid']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['nid']['alter']['absolute'] = 0;
$handler->display->display_options['fields']['nid']['alter']['trim'] = 0;
$handler->display->display_options['fields']['nid']['alter']['word_boundary'] = 1;
$handler->display->display_options['fields']['nid']['alter']['ellipsis'] = 1;
$handler->display->display_options['fields']['nid']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['nid']['alter']['html'] = 0;
$handler->display->display_options['fields']['nid']['hide_empty'] = 0;
$handler->display->display_options['fields']['nid']['empty_zero'] = 0;
$handler->display->display_options['fields']['nid']['link_to_node'] = 0;

/* Display: Page */
$handler = $view->new_display('page', 'Page', 'page_1');
$handler->display->display_options['defaults']['enabled'] = FALSE;
$handler->display->display_options['enabled'] = FALSE;
$handler->display->display_options['path'] = 'foo';

/* Display: Page */
$handler = $view->new_display('page', 'Page', 'page_2');
$handler->display->display_options['path'] = 'foo1';

I'm wondering whether it would make sense to move the setting to a button like "remove display".

The rest is RTBC

I'm wondering whether it would make sense to move the setting to a button like "remove display".

Probably yes.

Committed this. I think we can change the UI in a follow up patch if necessary but it's nice to have the feature.