theme('stylesheet_import'... in modules stops block/theme preview [#60096]

In http://drupal.org/node/52508#comment-79259 (and http://drupal.org/node/22218 ) it states that the correct way for modules to include css is to use

drupal_set_html_head(theme('stylesheet_import', base_path() . drupal_get_path('module', 'mymodule') .'/mymodule.css'));

Doing this though stops the theme preview from occuring when editing the blocks (switching the theme at the top of the blocks page should provide a preview).

Using theme_add_style('misc/local/my_custom_style.css'); correctly previews the theme, but according to the post above is definitely NOT supposed to be used.

I've put this as critical partly for the bug, but also because I notice some modules (eg event) are using the theme_add_style version. Some extra clarity is needed for module authors I think (like me:-)

Comments

Comment #1

Zen commented 24 April 2006 at 18:01

Category:	bug	» support
Priority:	Critical	» Normal

Please read http://drupal.org/node/52508

Changing to a support request. If you still face any issues, please recategorise this issue.

Thanks :)
-K

Comment #2

profix898 commented 24 April 2006 at 18:16

Priority:

Normal

» Critical

@Zen: You should read issues more carefully ;) The link you posted is the same listed in the issue description! It tells module developers to use drupal_set_html_head(theme('stylesheet_import', ...). But doing so makes it impossible to configure blocks per theme ...

Comment #3

kiz_0987 commented 24 April 2006 at 18:27

Category:

support

» bug

As per profix898, moving back to bug report.

Comment #4

Zen commented 24 April 2006 at 18:31

oops! Thanks for the cover profix :P

Setting it back to bug report.

-K

Comment #5

dries commented 24 April 2006 at 19:19

The difference between both functions is not clear based on looking at their name. Hence, the confusion. Using theme_add_style('misc/local/my_custom_style.css'); appears to make sense.

It would be a good idea to clean up the naming scheme (or to eliminate the need for both functions). Probably some post 4.7.0 task.

Comment #6

chx commented 25 April 2006 at 05:21

Project:	Drupal core	» Documentation
Component:	block.module	» Developer Guide

Comment #7

kiz_0987 commented 25 April 2006 at 10:33

I can see the need for improved documentation, but there is still a bug here. drupal_set_html_head(theme('stylesheet_import', base_path() . drupal_get_path('module', 'mymodule') .'/mymodule.css')); stops theme preview from working. Or is the documentation going to say "don't use drupal_set_html_head(theme('stylesheet_import', ..."?

Comment #8

heine commented 25 April 2006 at 11:33

The problem of theme('stylesheet_import') in hook_menu or hook_init is the call to theme(), initializing the theme system. Later calls to init_theme silently return & the switch fails.

The theme_add_style('misc/local/my_custom_style.css'); or theme_stylesheet_import do not call the theme function so the switch can still happen.