Menu item disappeared after a node deletion

Miteto - October 10, 2009 - 23:30
Project:Taxonomy Menu
Version:6.x-2.4-beta1
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

That's it - clean install, no contributed modules but Taxonomy Menu. When I delete a node tagged "white", menu item "white" disappears. I nave to uncheck "Syncronise changes to this vocabulary" to stop this. Same thing with the latest dev version.
Drupal - 6.14.

#1

elprans - October 15, 2009 - 22:54

This is caused by a nasty bug in Taxonomy Menu synchronization code. The patch that fixed this for me is attached. This should also fix #514640: Duplication of terms.

AttachmentSize
0001-Fix-a-number-of-bugs-that-led-to-a-horrible-menu-cor.patch 1.85 KB

#2

elprans - October 15, 2009 - 23:57

Updated patch

AttachmentSize
Fix-Menu-Corruption-v2.patch 2.18 KB

#3

indytechcook - October 16, 2009 - 12:25

Very good work elphrans. Thank you very much. It's tough to do hard core debugging with a full time job and 4 month old baby.

I agree with your statement about now running the rebuild every time a node is change. The only time it needs to run is if the option "show node count" or "hide empty terms" is enabled. Currently is always runs. I will create a new issue and a new patch for that.

Quick question. Is this patch for DRUPAL-6--2 branch for the DRUPAL-6--2-4-BETA1 release?

#4

elprans - October 16, 2009 - 17:06

The patch is against DRUPAL-6--2-4-BETA1

#5

indytechcook - October 18, 2009 - 01:16
Status:active» needs review

This has been commited. Please look for the dev release soon. If it fixes the issue, then please post here and I will add a new stable release.

Thanks again to elprans for fixing this long standing issues.

#6

NaX - October 27, 2009 - 06:41

I think this patch fixed a nasty bug I ran into. http://drupal.org/node/383780
I can’t confirm if this patch fixed the problem but after rebuilding and clearing cache the errors went away.

I think another beta release is in order.

#7

indytechcook - October 31, 2009 - 18:45
Status:needs review» fixed

This is part of 6.x-2.4-beta2. Since Nax reported it fixed the issue, setting to fixed.

#8

System Message - November 14, 2009 - 18:50
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.