Download & Extend
Vertical Tabs » Issues

Vertical Tabs not showing summary for Vocabularies and Flags fieldsets

Posted by andrewmacpherson on October 11, 2009 at 3:40am
Project:Vertical Tabs
Version:6.x-1.x-dev
Component:User interface
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

The summary for the vocabularies fieldset shows "No terms", whether vocabulary terms are selected or not. Likewise, the Flags fieldset summary shows "No flags" at all times.

AttachmentSize
vertical-tabs-vocab-summary-bug.png24.08 KB
vertical-tabs-flags-summary-bug.png18.58 KB
Login or register to post comments

Comments

#1

Posted by andrewmacpherson on October 11, 2009 at 3:46am

Here's a patch to fix it. Two jQuery selectors were at fault, looking for div elements instead of fieldset.

AttachmentSize
vertical_tabs-601260.patch 1.19 KB
vertical_tabs-601260-vocab-summary-fix.png 26.73 KB
vertical_tabs-601260-flags-summary-fix.png 21.6 KB

#2

Posted by andrewmacpherson on October 11, 2009 at 3:53am
Status:active» needs review

forgot to update status with the patch

#3

Posted by Les Lim on November 6, 2009 at 9:45pm
Status:needs review» reviewed & tested by the community

Good catch. RTBC.

#4

Posted by Dave Reid on November 6, 2009 at 11:32pm
Status:reviewed & tested by the community» fixed

Committed to CVS (http://drupal.org/cvs?commit=285300). Thanks!

#5

Posted by System Message on November 20, 2009 at 11:40pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#6

Posted by gooddesignusa on February 28, 2010 at 11:48pm

Sorry to reopen. Still seems to be an issue. Happened to me today with 6.x-1.0-rc1. Not sure if its taxonomy super select causing it since i didn't have time to test. Not really a big deal.

#7

Posted by cybermache on February 21, 2011 at 5:24pm
Status:closed (fixed)» needs work

I am also using 6.x-1.0-rc1. I originally thought it was an issue with Taxonomy Super Select. It still could be, I am not quite sure.

Turning off TSS outputs the fieldset title of the vocabulary followed by the terms in the vertical tab. Turning TSS on again only displays 'No Terms' in the vertical tab if all Vocab groups have TSS selected for them. Perhaps this has something to do with how VT is calling the terms and how TSS is outputting that value.

I am not using Flags so I can not confirm if this has the same affect. If this is indeed a TSS issue please let me know so I can post this issue there.

Thanks

#8

Posted by Dave Reid on February 21, 2011 at 5:53pm
Status:needs work» closed (fixed)

If a module changes the way the taxonomy forms work, then it needs to provide its own summary JavaScript file.

#9

Posted by cybermache on February 21, 2011 at 7:41pm

Thanks for the response Dave. Could you possibly elaborate on your statement? Or if you don't feel like doing that can you suggest where my inquiry might receive more help?

Is this be something that should get posted to the TSS issue feed? For example.

Thanks

nobody click here