Status messages not styled when displayed inline

webchick - October 12, 2009 - 04:43
Project:Drupal
Version:7.x-dev
Component:Seven theme
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Issue tags:Novice, Quick fix
Description

Here's a screenshot from the #560780: Add Image Field to image.module patch, which displays a status message inline:

Status message - Seven

I think this is a bug in the theme because in Garland it looks fine:

Status message - Garland

I am no kind of CSS expert, but I'm guessing this is pretty easy to fix. Tagging as Novice.

#1

sivaji - October 12, 2009 - 09:36
Status:active» needs review
Issue tags:+Quick fix

In themes/seven/style.css from line no 116 to 140 changing

#console div.messages {
  padding: 9px;
  margin: 1em 0;
  color: #036;
  background: #bdf;
  border: 1px solid #ace;
}

#console div.warning {
  color: #840;
  background: #fe6;
  border-color: #ed5;
}

#console div.error {
  color: #fff;
  background: #e63;
  border-color: #d52;
}

#console div.status {
  color: #360;
  background: #cf8;
  border-color: #be7;
}

to

div.messages {
  padding: 9px;
  margin: 1em 0;
  color: #036;
  background: #bdf;
  border: 1px solid #ace;
}

div.warning {
  color: #840;
  background: #fe6;
  border-color: #ed5;
}

div.error {
  color: #fff;
  background: #e63;
  border-color: #d52;
}

div.status {
  color: #360;
  background: #cf8;
  border-color: #be7;
}

Will fix this.

AttachmentSizeStatusTest resultOperations
Screenshot-1.png99.37 KBIgnoredNoneNone

#2

sivaji - October 12, 2009 - 12:55

Attached patch will fix this.

AttachmentSizeStatusTest resultOperations
601972-status-message-not-styled-1.patch1009 bytesIdlePassed: 13292 passes, 0 fails, 0 exceptionsView details | Re-test

#3

arianek - October 17, 2009 - 22:19

patch applied cleanly to head. looks good to me, screenshot:

going to leave this open for a code review yet, i think rickvug is going to have a look at it shortly before we RTBC it.

#4

arianek - October 17, 2009 - 22:21

dang, screenshot fail, here we go

AttachmentSizeStatusTest resultOperations
imgmessage.jpg28.49 KBIgnoredNoneNone

#5

rickvug - October 17, 2009 - 22:28
Status:needs review» reviewed & tested by the community

Double checked this and the changes look good to me. The code comment change to switch the heading from "console" to "messages" makes a whole lot more sense also. RTBC.

#6

webchick - October 18, 2009 - 04:35
Status:reviewed & tested by the community» fixed

Awesome, thanks! :)

Committed to HEAD!

#7

System Message - November 1, 2009 - 04:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.