This is more a FYI than anything;

To my understanding, flag module has a 2.x branch that has various features; including a way to alter options (it's a drupal_alter instead of the hooks that someone else proposed). May be a good idea to wait to change flag_note into flag_history and flag_note till flag 2.x-dev is more ready and make a 2.x instead?

Anyhow one of those changes with the alter is additional events are possible. flag_abuse module is using that to change the $action for a global reset option it needs (ie insted of just flag, unflag it's flag, unflag, reset as actions with flag_abuse.)

Flag note changes the link to flag/note/etc. and uses the flag_note_page, which only handles flag/unflag. If neither are supplied there's no error handling (case statement doesn't have a default). and the page returns as a white page. For now, might be a good idea to call flag_page in default case statement. (here's the issue in #601724: Issue with flag abuse+flag note filled in flag_abuse; wasn't sure which module it should have been filled under).

CommentFileSizeAuthor
flag_note_default_page.patch359 byteshefox

Comments

gunzip’s picture

patch committed to -dev. thank you (did you apply for a cvs account then ?)

May be a good idea to wait to change flag_note into flag_history and flag_note till flag 2.x-dev is more ready and make a 2.x instead?

i will wait for sure cause merely i don't have much time at the moment.

gunzip’s picture

Status: Active » Fixed
hefox’s picture

Cool, thanks.

(I plan to apply.... soon. Maybe after this damn site launches ;-; The cvs application instructions are a bit scary/long :(. )

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.