Project:Hashcash
Version:6.x-2.1
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

  1. Add @file PHPdoc.
  2. Use the correct hook documentation ("Implementation of hook_foo().")
  3. Fixed coding standards with hashcash_schema().
  4. You should *not* ever call menu_rebuild() directly. If you want to force users to run update.php (which automatically rebuilds the menu afterwards), all you need to do is add an 'empty' update function.

Comments

#1

Status:active» needs review
AttachmentSize
602318-hashcash-cleanup-install-D6.patch 1.84 KB

#2

Status:needs review» fixed

Point four is a valid one, I'll remove that if an update is required.

#3

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.