1. Add @file PHPdoc.
  2. Use the correct hook documentation ("Implementation of hook_foo().")
  3. Fixed coding standards with hashcash_schema().
  4. You should *not* ever call menu_rebuild() directly. If you want to force users to run update.php (which automatically rebuilds the menu afterwards), all you need to do is add an 'empty' update function.
CommentFileSizeAuthor
#1 602318-hashcash-cleanup-install-D6.patch1.84 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 602318-hashcash-cleanup-install-D6.patch1.84 KB
sdrycroft’s picture

sdrycroft commented
Status: Needs review » Fixed

Point four is a valid one, I'll remove that if an update is required.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.