| Project: | Multiple Node Menu |
| Version: | 6.x-1.x-dev |
| Component: | Miscellaneous |
| Category: | bug report |
| Priority: | normal |
| Assigned: | PeteS |
| Status: | closed (fixed) |
Issue Summary
I seem to be one of two people trying this out! Which is weird, because it's a great idea and would make some maintenance tasks much easier for laypersons.
Anyway, here's my issue:
Installed the module on Drupal 6.14. Tried using it with three nodes to add the nodes to navigation:
First, with a Composite Layout page, I tried adding to two menus.
Second, with a normal Story node, tried adding to two menus.
Finally, with a normal story node, tried adding to a single menu.
In each case the menu options were added to the Navigation menu, not to the menus I selected as parent.
I was able to move them to other menus without a problem. However, when I edited the node from which I had originally created the menu entries, the Parent item for both menu entries showed as Primary Links.
Some other stuff I'm running right now that might have bearing:
Menu attributes
Menu trails
Most likely won't be using this module on the site I'm working on (will just go back to maintaining the Primary Links entry from the node and doing other entries manually), so this isn't by any means an urgent request.
Comments
#1
#2
I confirm this bug.
Each time I add a new menu link in the node edit form it gets added to the Navigation menu although I've specified another menu.
I really need this functionality for one of my ongoing projects, so I'll try to look into this, but if you do have an idea of where this is comming from, that could help me get a patch together.
---
Oussama Mubarak // Semiaddict
#3
I have completely revisited the module's code fixing the bug.
Some other changes done:
1) unset the original menu settings form as it is not needed anymore.
2) removed the delete button. To remove a menu item, simply clear its title.
I'm attaching the patch as well as a zip file with the modified module
---
Oussama Mubarak // Semiaddict
#4
I have tried above multiple_node_menu.zip file but its not working for me.
#5
Kuldip, could you please give me more info?
What is not working for you?
Thank you.
#6
The zip version works great for me. I will use this in a new project for one of our clients. If I find any bugs I will let you know!
Thanks for this great feature...
#7
I recently needed to be able to select which menus are available in the dropdown lists (to exclude administration menus for example), so I added an admin page to select the menus.
Attached is the new patch with that change and couple of code enhancements, as well as a zip file with the modified module
N.B: The admin page is located at admin/settings/multiple_node_menu
---
Oussama Mubarak // Semiaddict
#8
Thanks semiaddict. I took a look at your code, and there are a number of good improvements in there -- namely, fixing this bug, and the admin settings page to control which menus are available for selection.
However, I'm not such a big fan of removing the draggable feature from the table, or removing the "Delete" button (I think the clear title-to-delete method is not particularly intuitive). I'm also not sure that the add new item button works anymore with the on submit removed.
In any case, I merged many of the changes, and hope to make additional improvements based on what you uploaded, particularly to take out some of the inefficient code that could be condensed. A new version will be uploaded in a few minutes.
As far as the UI is concerned, I'm hesitant to completely replace the original Drupal menu form there, because it's a pretty familiar interface for most people. I think there should probably be a proper discussion about how best to modify the form.
#9
Also note that I'm assuming the menu parent bug to be the same one that is forcing it for me, and the other related bug post, to revert to "Primary links." I'm assuming it has something to do with your menu configurations, as to why it's reverting to "Navigation" for you guys.
Will close out all of the (current) issues once the latest snapshot goes live.
#10
#11
Automatically closed -- issue fixed for 2 weeks with no activity.