Closed (fixed)
Project:
Ubercart
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
12 Oct 2009 at 19:34 UTC
Updated:
27 Oct 2009 at 14:20 UTC
Most calls to round() have been removed in recent commits so that prices with more than two decimal places are correctly handled. However, rounding code still remains in uc_quote.js so shipping prices are always rounded to 2dp. This can cause minor calculation errors in the order preview pane when prices with greater precision are needed such as by uc_vat. For an example see xibun's post at http://drupal.org/node/600478#comment-2141954
Patch attached that removes the calls to Math.round(). This doesn't seem to cause any adverse effects, I'm not really sure why the calls were there in the first place.
| Comment | File | Size | Author |
|---|---|---|---|
| uc_quote-remove-rounding.patch | 2.45 KB | longwave |
Comments
Comment #1
xibun commentedPatch tested -> problem fixed. Brilliant, thanks longwave!
I've looked at the original code and the patch, too me it looks good.
Comment #2
Island Usurper commentedThanks for finding and fixing that, longwave. Committed.