Warning notice displays when in admin/settings/image:
warning: Parameter 1 to theme_image_settings_sizes_form() expected to be a reference, value given in /srv/www/htdocs/zus/includes/theme.inc on line 617.
When I switch from reference to actual variable in theme_image_settings_sizes_form function, warning disappears. Was reference intended or not?

CommentFileSizeAuthor
image.admin_.inc_.patch508 bytesVin7

Comments

joachim’s picture

joachim commented
Status: Needs review » Fixed

I don't get that warning -- have you got E_ALL on maybe?
But looking at http://api.drupal.org/api/drupal/developer--topics--forms_api.html you're right -- the $form element should be passed in as a value not a reference.

Thanks for the patch :)
For future reference though, don't leave commented-out old code in a patch, and don't add lines crediting yourself. The code would quickly become unreadable with those in.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

willazilla’s picture

willazilla commented

I'm getting this error -> warning: Parameter 1 to theme_image_settings_sizes_form() expected to be a reference, value given in /opt/lampp/htdocs/uberdru/includes/theme.inc on line 617.

on Version 6.14. Can I use the patch to fix it?

joachim’s picture

joachim commented

6.14 is Drupal core.
Download the latest dev of image.