Posted by aufumy on October 13, 2009 at 3:28pm
6 followers
| Project: | Apache Solr Search Integration |
| Version: | 7.x-1.x-dev |
| Component: | Language |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
use tt() from i18n to translate the node types shown in the filter by type block
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| apachesolr_i18n_nodetype.patch | 1.78 KB | Ignored: Check issue status. | None | None |
Comments
#1
See my comments here: #602668-1: Translate the node type token
#2
using a wrapper function for tt().
#3
Marked #590346: content type name translation duplicate.
#4
#5
function_exists() is surely faster than module_exists(), so I would still tend to go that route.
#6
really? module_exists uses module_list's static cache. And module_list is called all over the place. In fact, I'm the one who suggested for these related patches to use module_exists. And array_key_exists() has to be way faster then function_exists() assuming the module comes out of the static cache.
#7
A call to function_exists() isn't as self-documenting as a call to module_exists(), and as the call is not in a critical path and as the speed difference is not significant, I favor module_exists().
#8
I was asked at http://drupal.org/node/394728#comment-3145722 if this issue could be moved to Apache Solr Multilingual.
Like I pointed out at http://drupal.org/node/436578#comment-2829254 it has to be solved in Apache Solr Search Integration itself.
#9
ok, so let's get it done.
#10
Based on http://drupal.org/node/609364 and http://drupal.org/node/304002 this seems like a sensible way to do it.
Applied to 5--2, 6--1, and 6--2. Didn't commit to HEAD as I don't know how tt() changed in D7.
#11
Create issue in Facet API queue if still an issue.
#12
Automatically closed -- issue fixed for 2 weeks with no activity.