Closed (fixed)
Project:
Apache Solr Search
Version:
7.x-1.x-dev
Component:
Language
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Oct 2009 at 15:28 UTC
Updated:
28 May 2011 at 18:21 UTC
Jump to comment: Most recent file
Comments
Comment #1
Scott Reynolds commentedSee my comments here: #602668-1: Translate the node type token
Comment #2
aufumy commentedusing a wrapper function for tt().
Comment #3
jpmckinney commentedMarked #590346: content type name translation duplicate.
Comment #4
jpmckinney commentedComment #5
pwolanin commentedfunction_exists() is surely faster than module_exists(), so I would still tend to go that route.
Comment #6
Scott Reynolds commentedreally? module_exists uses module_list's static cache. And module_list is called all over the place. In fact, I'm the one who suggested for these related patches to use module_exists. And array_key_exists() has to be way faster then function_exists() assuming the module comes out of the static cache.
Comment #7
jpmckinney commentedA call to function_exists() isn't as self-documenting as a call to module_exists(), and as the call is not in a critical path and as the speed difference is not significant, I favor module_exists().
Comment #8
mkalkbrennerI was asked at http://drupal.org/node/394728#comment-3145722 if this issue could be moved to Apache Solr Multilingual.
Like I pointed out at http://drupal.org/node/436578#comment-2829254 it has to be solved in Apache Solr Search Integration itself.
Comment #9
pwolanin commentedok, so let's get it done.
Comment #10
jpmckinney commentedBased on http://drupal.org/node/609364 and http://drupal.org/node/304002 this seems like a sensible way to do it.
Applied to 5--2, 6--1, and 6--2. Didn't commit to HEAD as I don't know how tt() changed in D7.
Comment #11
jpmckinney commentedCreate issue in Facet API queue if still an issue.