New Interface - Testing Needed

slampy - October 13, 2009 - 16:09
Project:Image Browser
Version:6.x-2.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:needs review
Description

I think FCKEditor's big advantage is that it doesn't use popups and has it's own javascript dialog boxes.

It would be great to see Image Browser use these dialog boxes and not a popup window.

#1

Starnox - October 15, 2009 - 22:07
Title:Use of FCKEditors own dialog box» Create custom AJAX & iFrame dialog box
Status:active» postponed

Agreed they are much better, however I realised we can't restrict ourselves to them if we want to add WYSIWYG API support and have it so you could open IB from other sources like FileField. A custom pop-up allows us to keep IB universal. Maybe we could work on our own custom AJAX and iFrame dialog box which works like FCK's... it's not a priority however. Feel free to post patches ;)

#2

Starnox - October 16, 2009 - 20:59

Something looking like this would be cool. Just need to figure out how to make FCKeditor do the business.

AttachmentSize
Screen shot 2009-10-16 at 21.54.53.png 240.14 KB

#3

Starnox - October 16, 2009 - 21:44

Hmm I'm very close to getting this working. Just need to find out how to pass through the FCK iFrame ID the ImageBrowser button was pressed from.

My solution works, but only if there is one instance of an FCKeditor on the page.

#4

Starnox - October 16, 2009 - 22:05

Sweet I've got it all working. Just need to tidy up the code, and make sure the 'dialog box' is always in the center even if you have scrollbars etc. then I'll release the dev copy for testing in other browsers apart from Safari and Firefox.

#5

Starnox - October 17, 2009 - 09:40

Welcome to the new interface of IBv2.

AttachmentSize
Screen shot 2009-10-17 at 10.39.06.png 342.83 KB

#6

igorik - October 17, 2009 - 10:12

Wau, it looks so amazing. I can't wait till i trying a new version of IB 2.x . Thanks Starnox, I am your big fan. :)

#7

Starnox - October 18, 2009 - 11:09
Title:Create custom AJAX & iFrame dialog box» New Interface - Testing Needed

OK so I've uploaded the new interface to the demo site. Clear your browser cache if you run into issues:

http://ib2.coredesigns.co.uk/

Testing needed on other browsers, screenshots attached so you know what it's meant to look like.

Tested

  • Safari 4 on Mac OS 10.6 - OK
  • Firefox 3.5 on Mac OS 10.6 - OK
  • Firefox 3.5 on WinXP - OK
  • Opera 10 on Mac OS 10.6 - OK
  • Chrome on Mac OS 10.6 - OK
  • IE 8 on WinXP - OK

If things don't work either post JS errors or screenshots for CSS issues. Cheers guys.

AttachmentSize
Screen shot 2009-10-17 at 12.40.23.png 161.48 KB
Screen shot 2009-10-17 at 12.40.37.png 43.56 KB

#8

Starnox - October 17, 2009 - 11:44
Status:postponed» needs review

#9

igorik - October 18, 2009 - 11:14

It works great in FF 3.5.3 WinXP and IE8 WinXP
EDIT: I found that cursor on green button Upload New doesn't change to pointer, it is like text cursor (FF 3.5.3 on Win XP).
and I found that there is in IE8 button Upload new totally bad. I attached sreenshot from IE8 on Win XP

#10

igorik - October 18, 2009 - 11:12

this is a screenshot from IE 8 on Windows XP

AttachmentSize
imagebrowser_new_design2.gif 60.55 KB

#11

Starnox - October 18, 2009 - 11:17

Ok reckon you could try again in IE8? Might need to do a clear cache / refresh.

#12

Starnox - October 18, 2009 - 11:20

Yeah I get the same on Firefox in OS 10 on the cursor front. I think it's a firefox bug because even setting the cursor: pointer; in CSS doesn't do anything. Maybe you can't overwrite the cursor property on form elements in Firefox?

#13

igorik - October 18, 2009 - 11:31

Hi, Now Upload button looks and works like a charm. Great.
I noticed one more thing on ie, background si completly white, there is no transparency in IE.
Screenshot attached

AttachmentSize
imagebrowser_new_design3.gif 68.68 KB

#14

igorik - October 18, 2009 - 11:30

BTW In IE8 the cursor is changing right to pointer on green upload button. So probably it will really Firefox issue only

#15

Starnox - October 18, 2009 - 11:34

Ok completely white bg should be fixed as well.

#16

igorik - October 18, 2009 - 11:43

Yes, I can confirm, completly white bg is now fixed in IE8. Oooh, now it looks so awesome! :)
Thanks

#17

lgierth - October 22, 2009 - 23:05

Hi,

1) the close button is being misplaced in Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.14) Gecko/2009090216 Ubuntu/9.04 (jaunty) Firefox/3.0.14.
2) the wrong pointer icon is being used when hovering the upload button (same browser).

Best regards,
Lars

EDIT:
I just noticed that X messed up the second screenshot. The pointer that actually shows up is the pipe-like on being used when hovering text in the browser or in a text processor.

AttachmentSize
imagebrowser-misplaced-close-button-in-firefox-3.0.14.png 281.04 KB
imagebrowser-wrong-pointer-icon-on-upload-button-in-firefox-3.0.14.png 274.23 KB

#18

lgierth - October 27, 2009 - 00:45

Hi,

patch for #17.1 attached. Fixes problem in Firefox 3.0.14, causes no problems at least in Chromium 4.0.223.6~svn20091020r29510.

Best regards,
Lars

AttachmentSize
imagebrowser-misplaced-closed-button-fix.patch 598 bytes
 
 

Drupal is a registered trademark of Dries Buytaert.