I think FCKEditor's big advantage is that it doesn't use popups and has it's own javascript dialog boxes.

It would be great to see Image Browser use these dialog boxes and not a popup window.

CommentFileSizeAuthor
#18 imagebrowser-misplaced-closed-button-fix.patch598 byteslgierth
#17 imagebrowser-misplaced-close-button-in-firefox-3.0.14.png281.04 KBlgierth
#17 imagebrowser-wrong-pointer-icon-on-upload-button-in-firefox-3.0.14.png274.23 KBlgierth
#13 imagebrowser_new_design3.gif68.68 KBigorik
#10 imagebrowser_new_design2.gif60.55 KBigorik
#7 Screen shot 2009-10-17 at 12.40.23.png161.48 KBjdelaune
#7 Screen shot 2009-10-17 at 12.40.37.png43.56 KBjdelaune
#5 Screen shot 2009-10-17 at 10.39.06.png342.83 KBjdelaune
#2 Screen shot 2009-10-16 at 21.54.53.png240.14 KBjdelaune

Comments

jdelaune’s picture

jdelaune commented
Title: Use of FCKEditors own dialog box » Create custom AJAX & iFrame dialog box
Status: Active » Postponed

Agreed they are much better, however I realised we can't restrict ourselves to them if we want to add WYSIWYG API support and have it so you could open IB from other sources like FileField. A custom pop-up allows us to keep IB universal. Maybe we could work on our own custom AJAX and iFrame dialog box which works like FCK's... it's not a priority however. Feel free to post patches ;)

jdelaune’s picture

jdelaune commented
StatusFileSize
new Screen shot 2009-10-16 at 21.54.53.png240.14 KB

Something looking like this would be cool. Just need to figure out how to make FCKeditor do the business.

jdelaune’s picture

jdelaune commented

Hmm I'm very close to getting this working. Just need to find out how to pass through the FCK iFrame ID the ImageBrowser button was pressed from.

My solution works, but only if there is one instance of an FCKeditor on the page.

jdelaune’s picture

jdelaune commented

Sweet I've got it all working. Just need to tidy up the code, and make sure the 'dialog box' is always in the center even if you have scrollbars etc. then I'll release the dev copy for testing in other browsers apart from Safari and Firefox.

jdelaune’s picture

jdelaune commented
StatusFileSize
new Screen shot 2009-10-17 at 10.39.06.png342.83 KB

Welcome to the new interface of IBv2.

igorik’s picture

igorik commented

Wau, it looks so amazing. I can't wait till i trying a new version of IB 2.x . Thanks Starnox, I am your big fan. :)

jdelaune’s picture

jdelaune commented
Status: Needs review » Postponed
StatusFileSize
new Screen shot 2009-10-17 at 12.40.37.png43.56 KB
new Screen shot 2009-10-17 at 12.40.23.png161.48 KB

OK so I've uploaded the new interface to the demo site. Clear your browser cache if you run into issues:

http://ib2.coredesigns.co.uk/

Testing needed on other browsers, screenshots attached so you know what it's meant to look like.

Tested

  • Safari 4 on Mac OS 10.6 - OK
  • Firefox 3.5 on Mac OS 10.6 - OK
  • Firefox 3.5 on WinXP - OK
  • Opera 10 on Mac OS 10.6 - OK
  • Chrome on Mac OS 10.6 - OK
  • IE 8 on WinXP - OK

If things don't work either post JS errors or screenshots for CSS issues. Cheers guys.

jdelaune’s picture

jdelaune commented
Title: Create custom AJAX & iFrame dialog box » New Interface - Testing Needed
Status: Postponed » Needs review
igorik’s picture

igorik commented

It works great in FF 3.5.3 WinXP and IE8 WinXP
EDIT: I found that cursor on green button Upload New doesn't change to pointer, it is like text cursor (FF 3.5.3 on Win XP).
and I found that there is in IE8 button Upload new totally bad. I attached sreenshot from IE8 on Win XP

igorik’s picture

igorik commented
Status: Postponed » Needs review
StatusFileSize
new imagebrowser_new_design2.gif60.55 KB

this is a screenshot from IE 8 on Windows XP

jdelaune’s picture

jdelaune commented

Ok reckon you could try again in IE8? Might need to do a clear cache / refresh.

jdelaune’s picture

jdelaune commented

Yeah I get the same on Firefox in OS 10 on the cursor front. I think it's a firefox bug because even setting the cursor: pointer; in CSS doesn't do anything. Maybe you can't overwrite the cursor property on form elements in Firefox?

igorik’s picture

igorik commented
StatusFileSize
new imagebrowser_new_design3.gif68.68 KB

Hi, Now Upload button looks and works like a charm. Great.
I noticed one more thing on ie, background si completly white, there is no transparency in IE.
Screenshot attached

igorik’s picture

igorik commented

BTW In IE8 the cursor is changing right to pointer on green upload button. So probably it will really Firefox issue only

jdelaune’s picture

jdelaune commented

Ok completely white bg should be fixed as well.

igorik’s picture

igorik commented

Yes, I can confirm, completly white bg is now fixed in IE8. Oooh, now it looks so awesome! :)
Thanks

lgierth’s picture

lgierth commented
StatusFileSize
new imagebrowser-wrong-pointer-icon-on-upload-button-in-firefox-3.0.14.png274.23 KB
new imagebrowser-misplaced-close-button-in-firefox-3.0.14.png281.04 KB

Hi,

1) the close button is being misplaced in Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.14) Gecko/2009090216 Ubuntu/9.04 (jaunty) Firefox/3.0.14.
2) the wrong pointer icon is being used when hovering the upload button (same browser).

Best regards,
Lars

EDIT:
I just noticed that X messed up the second screenshot. The pointer that actually shows up is the pipe-like on being used when hovering text in the browser or in a text processor.

lgierth’s picture

lgierth commented
StatusFileSize
new imagebrowser-misplaced-closed-button-fix.patch598 bytes

Hi,

patch for #17.1 attached. Fixes problem in Firefox 3.0.14, causes no problems at least in Chromium 4.0.223.6~svn20091020r29510.

Best regards,
Lars