Show and hide of pager options on theme change

Steps to reproduce

Check Advanced

Change theme to one with limited pager options (like upright20).

Pager options changed to 'prev-next' only.

Uncheck advanced options.

Pager still only 'prev-next'.

Save, and pager still prev-next since the hiding is done onload also.

There's no action on advanced options so hiding done via theme change remains after unchecking advanced options, from what I can tell

Actually, this is is much worse than I though.

Since the default template is upright10 for those not using advanced settings, every time it's hiding the prev-next option so re configurig and saving a block the settings are always lost unless manually going up and doing the whole check, select, uncheck and then change pager. It's quite annoying.

I'm trying to use the previous-next pager. In order for the javascript to realize that it needs to be set in the ddblock settings. So I go to the block configuration and the previous-next pager option is not there. In order to get the previous--next pager option to show up, I need:

to check Advanced Settings

Change to a theme that I know has a previous-next pager

  $('#ddblock-instance-settings #edit-template:not(.ddblock-show-hide-custom-template-options-processed)', context)
  .addClass('ddblock-show-hide-custom-template-options-processed')
  .bind("change", function() {
    val = $('#ddblock-instance-settings #edit-template').val();
    //alert(val);
    switch (val) {
    case "custom" :
      $("#ddblock-custom-template-settings-wrapper").show();
    case "upright10" :
      $('#edit-pager-wrapper #edit-pager').val('number-pager');
      $('#edit-pager-wrapper option[value="number-pager"]').show();
      $('#edit-pager-wrapper option[value="prev-next-pager"]').hide();
      $('#edit-pager-wrapper option[value="custom-pager"]').hide();

That is run, so I check upright20 to get the prev-next pager to show.

Then I uncheck advanced options, and previous-next is now able to be selected via the select box.

Ie.

Drupal.behaviors.ddblockShowHideAdvancedOptions = function(context) {
  // Show/hide slide advanced options depending on the checkbox.
  $('#ddblock-instance-settings #edit-advanced:not(.ddblock-show-hide-advanced-options-processed)', context)
  .addClass('ddblock-show-hide-advanced-options-processed')
  .bind("click change", function() {
    if (this.checked) {

does not .show or .hide the the Number or previous-next pager making it's visibility depend on the the (invisible) theme settings.

I'm trying to set the pager to previous-next, that is all. I do not want to use advanced options because I don't have any need for that functionality.

I have no need to make a custom ddblock theme when everything I want to do can be accomplished in an overridden ddblock-content.tpl.php in my theme folder. However, previous and next needs to be selected via that multistep hide/unhide ever time I configure that block due to the hide() onchange of theme.

I don't think this is a feature request, but a bug report which may be leading to the confusion.

The first image is the pager field before doing that check advanced, change themes, then uncheck adanced.

The second image is right after; the number pager is no longer available (though the select list still sees it as selected so shows in the select title, however it's not an option in the dropdown) but the previous-next pager.

The third image is the dbblock-cycle-block-content.tpl.php where it checks if the pager is previous-next and use the markup for that instead. The template file supports it; I don't see why the module wouldn't when it's purely a show/hide causing the issue.

As far as I can tell, there is nothing in the onchange advanced settings that is limiting the pager's previous-next option. That is one part of the bug. Also, there's nothing in the onchange function of theme function that checks if advanced settings is checked. That is other part of the bug, since as far as I can tell it's being invoked on page load and limiting the options even if advanced settings is unchecked.

After I get it to say previous-next my showcase block works perfectly fine; this is purely about the block configuration page I believe.